Re: [PATCH v2] PM/OPP: Set cpu_dev->id in cpumask first

Viresh Kumar
2015-12-29T03:50:54Z

On 28-12-15, 21:06, Pi-Cheng Chen wrote:
> Set cpu_dev->id in cpumask first when setting up cpumask for CPUs that
> share the same OPP table. This might be helpful when handling cpumask
> without the original CPU bitfield set.
>
> Signed-off-by: Pi-Cheng Chen <pi-cheng.chen@linaro.org>
> ---
> v1->v2:
> - Set cpu_dev->id in cpumask at the top instead of skip it in the loop
> ---
> drivers/base/power/opp/cpu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/power/opp/cpu.c b/drivers/base/power/opp/cpu.c
> index 7b445e8..9f0c155 100644
> --- a/drivers/base/power/opp/cpu.c
> +++ b/drivers/base/power/opp/cpu.c
> @@ -214,7 +214,6 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_of_cpumask_add_table);
> /*
> * Works only for OPP v2 bindings.
> *
> - * cpumask should be already set to mask of cpu_dev->id.
> * Returns -ENOENT if operating-points-v2 bindings aren't supported.
> */
> int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask)
> @@ -230,6 +229,8 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask
> return -ENOENT;
> }
>
> + cpumask_set_cpu(cpu_dev->id, cpumask);
> +
> /* OPPs are shared ? */
> if (!of_property_read_bool(np, "opp-shared"))
> goto put_cpu_node;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

--
viresh