Re: [PATCH v2 3/3] ARM64: dts: mt8173: Add CPU OPP, clock and regulator supply properties

Pi-Cheng Chen
2016-02-03T01:46:25Z

On Tue, Feb 2, 2016 at 10:09 PM, Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>
> On 02/02/16 12:06, Matthias Brugger wrote:
>>
>>
>>
>> On 05/01/16 11:24, Viresh Kumar wrote:
>>>
>>> On 05-01-16, 11:21, Arnd Bergmann wrote:
>>>>
>>>> On Monday 28 December 2015 08:43:40 Viresh Kumar wrote:
>>>>>
>>>>> On 27-12-15, 14:21, Pi-Cheng Chen wrote:
>>>>>>
>>>>>> Add operating-points-v2, clock, and regulator supply properties
>>>>>> required by mt8173-cpufreq driver to enable it.
>>>>>>
>>>>>> Signed-off-by: Pi-Cheng Chen <pi-cheng.chen-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>>>>> ---
>>>>>> This patch is based on the patch[1] that adds underlying clock MUX for
>>>>>> MT8173 which is needed by mt8173-cpufreq driver but not yet picked.
>>>>>>
>>>>>> [1] http://article.gmane.org/gmane.linux.kernel.clk/325
>>>>>> ---
>>>>>> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 18 ++++++
>>>>>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 90
>>>>>> +++++++++++++++++++++++++++++
>>>>>> 2 files changed, 108 insertions(+)
>>>>>
>>>>>
>>>>> Acked-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>>>>
>>>>
>>>> This patch is now in linux-next through Rafael's pm tree, and it
>>>> breaks the
>>>> arm64 build:
>>>>
>>>> arm64-defconfig
>>>> Error: ../arch/arm64/boot/dts/mediatek/mt8173.dtsi:132.24-25 syntax
>>>> error
>>>>
>>>>
>>>> Please revert.
>>>>
>>>> In the future, please send all dts changes through the proper maintainer
>>>> channels (-> Mattias -> arm-soc), and make sure they actually build.
>>>
>>>
>>> Rafael has already reverted that, AFAIK, after Mark Brown reported the
>>> build issue.
>>>
>>
>> Applied to v4.5-next/dts
>>
>
> I oversaw that this needs a clock patch, which is not yet mainlined.
> I deleted this patch from my tree.

I should mention that explicitly.
Sorry for the inconvenience.

Pi-Cheng