Re: [PATCH] dt-bindings: MediaTek: Add binding document for the AUXADC

[Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

Hi Matthias,

On Wed, Feb 24, 2016 at 03:36:46PM +0100, Matthias Brugger wrote:
> 
> 
> On 23/02/16 21:32, Rob Herring wrote:
> >On Fri, Feb 19, 2016 at 08:18:46AM +0100, Sascha Hauer wrote:
> >>Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> >>---
> >>
> >>This is a supplement to the MTK Thermal series which was lacking the
> >>description for the AUXADC.
> >
> >So it will be applied with that I presume.
> >
> >Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> >
> 
> Well the basic problem that I see is, that the auxadc has some more
> registers (at least in mt6589) for the touch screen registers.
> So this makes it a candidate for syscon and regmap.
> But this needs a patch in the thermal driver first...

When we want to have a driver for the auxadc we are free to write one.
No need to use syscon and/or regmap for it.

Note that the auxadc is not used by the thermal *driver*, it's used by
the thermal *hardware*. It's the hardware that directly reads/writes
auxadc registers. If MTK did it right then a real auxadc driver should
not be disturbed by the thermal controller accesses. At least from
checking the datasheet the registers the thermal controller accesses
are completely orthogonal to the ones a auxadc driver would use.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html