From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 2/3] mtd: mediatek: driver for MTK Smart Device Gen1 NAND Date: Fri, 18 Mar 2016 15:24:27 +0100 Message-ID: <20160318152427.672c3957@bbrezillon> References: <1456938013-8819-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1456938013-8819-3-git-send-email-jorge.ramirez-ortiz@linaro.org> <20160308172437.6eccce05@bbrezillon> <56E08112.7040201@linaro.org> <20160309214348.5aa78af5@bbrezillon> <56EC09F5.5020704@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56EC09F5.5020704-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Jorge Ramirez-Ortiz Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Fri, 18 Mar 2016 10:00:21 -0400 Jorge Ramirez-Ortiz wrote: > On 03/09/2016 03:43 PM, Boris Brezillon wrote: > > On Wed, 9 Mar 2016 15:01:22 -0500 > > Jorge Ramirez-Ortiz wrote: > > > >> On 03/08/2016 11:24 AM, Boris Brezillon wrote: > >>>> + switch (mtd->writesize) { > >>>>> + case KB(2): > >>>>> + fmt = PAGEFMT_512_2K; > >>>>> + chip->ecc.layout = &nand_2k_64; > >>>>> + break; > >>>>> + case KB(4): > >>>>> + fmt = PAGEFMT_2K_4K; > >>>>> + chip->ecc.layout = &nand_4k_128; > >>>>> + break; > >>>>> + case KB(8): > >>>>> + fmt = PAGEFMT_4K_8K; > >>>>> + break; > >>>>> + default: > >>>>> + dev_err(dev, "invalid page size: %d\n", mtd->writesize); > >>>>> + return -EINVAL; > >>>>> + } > >>> ecclayout info should be exposed through mtd_ooblayout_ops now. > >>> > >> do you have an approximate date for when this interface will be merged in > >> git://git.infradead.org/l2-mtd.git? > >> > > Should be ready for 4.7, in the meantime you can base your work on my > > branch [1] (which is based on l2-mtd/master). > > > > [1]https://github.com/bbrezillon/linux-0day/tree/nand/ecclayout > > > hi Boris, just a quick one, please could you confirm that you would like to see > the RFC v2 patch-set for this driver based on this branch? Yes, I confirm you can base your work on this tree. > or should we rebase on some other tree? You may have to rebase on a different tree after 4.6-rc1 is out though. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com