From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 1/2] mfd: mt6397: irq domain should initialize before mfd_add_devices() Date: Mon, 25 Apr 2016 11:54:24 +0100 Message-ID: <20160425105424.GA2713@dell> References: <1460709030-23820-1-git-send-email-henryc.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1460709030-23820-1-git-send-email-henryc.chen@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Henry Chen Cc: Matthias Brugger , John Crispin , Sascha Hauer , Flora Fu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On Fri, 15 Apr 2016, Henry Chen wrote: > Some sub driver like RTC module need irq domain from parent to create > irq mapping when driver initialize. so move mt6397_irq_init() before > mfd_add_devices(). >=20 > Acked-by: John Crispin > Signed-off-by: Henry Chen > --- > This series fixed the below warning based on "Linux kernel v4.6-rc1" > WARNING: CPU: 1 PID: 132 at kernel/mediatek/kernel/irq/irqdomain.c:47= 1 > irq_create_mapping+0xc4/0xd0 > =20 > Changes in V2: Add two patch for error handle checking. > Changes in V3: Add interrupt as required properties to dt-bindings do= c > --- > drivers/mfd/mt6397-core.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 8e8d932..b2faf56 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -267,15 +267,23 @@ static int mt6397_probe(struct platform_device = *pdev) > ret =3D regmap_read(pmic->regmap, MT6397_CID, &id); > if (ret) { > dev_err(pmic->dev, "Failed to read chip id: %d\n", ret); > - goto fail_irq; > + return ret; > } > =20 > + pmic->irq =3D platform_get_irq(pdev, 0); > + if (pmic->irq <=3D 0) > + return pmic->irq; > + > switch (id & 0xff) { > case MT6323_CID_CODE: > pmic->int_con[0] =3D MT6323_INT_CON0; > pmic->int_con[1] =3D MT6323_INT_CON1; > pmic->int_status[0] =3D MT6323_INT_STATUS0; > pmic->int_status[1] =3D MT6323_INT_STATUS1; > + ret =3D mt6397_irq_init(pmic); > + if (ret) > + return ret; > + > ret =3D mfd_add_devices(&pdev->dev, -1, mt6323_devs, > ARRAY_SIZE(mt6323_devs), NULL, 0, NULL); > break; > @@ -286,6 +294,10 @@ static int mt6397_probe(struct platform_device *= pdev) > pmic->int_con[1] =3D MT6397_INT_CON1; > pmic->int_status[0] =3D MT6397_INT_STATUS0; > pmic->int_status[1] =3D MT6397_INT_STATUS1; > + ret =3D mt6397_irq_init(pmic); > + if (ret) > + return ret; > + > ret =3D mfd_add_devices(&pdev->dev, -1, mt6397_devs, > ARRAY_SIZE(mt6397_devs), NULL, 0, NULL); > break; > @@ -296,14 +308,6 @@ static int mt6397_probe(struct platform_device *= pdev) > break; > } > =20 > - pmic->irq =3D platform_get_irq(pdev, 0); > - if (pmic->irq > 0) { > - ret =3D mt6397_irq_init(pmic); > - if (ret) > - return ret; > - } > - > -fail_irq: > if (ret) { > irq_domain_remove(pmic->irq_domain); > dev_err(&pdev->dev, "failed to add child devices: %d\n", ret); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog