From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: re: drm/mediatek: Add DPI sub driver Date: Thu, 12 May 2016 13:26:23 +0300 Message-ID: <20160512102622.GA14068@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: jie.qiu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org Hello Jie Qiu, This is a semi-automatic email about new static checker warnings. The patch 9e629c17aa8d: "drm/mediatek: Add DPI sub driver" from Jan 4, 2016, leads to the following Smatch complaint: drivers/gpu/drm/mediatek/mtk_dpi.c:436 mtk_dpi_set_display_mode() error: we previously assumed 'dpi' could be null (see line 435) drivers/gpu/drm/mediatek/mtk_dpi.c 434 435 if (!dpi) { ^^^^ Check. 436 dev_err(dpi->dev, "invalid argument\n"); ^^^^^^^^^ Deref. Can dpi even be NULL, btw? 437 return -EINVAL; 438 } regards, dan carpenter