From: Mark Brown <broonie@kernel.org>
To: John Crispin <john@phrozen.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Chen Zhong <chen.zhong@mediatek.com>
Subject: Re: [PATCH V8 2/2] regulator: mt6323: Add support for MT6323 regulator
Date: Mon, 11 Jul 2016 22:12:35 +0100 [thread overview]
Message-ID: <20160711211235.GB9976@sirena.org.uk> (raw)
In-Reply-To: <1468240179-7558-2-git-send-email-john@phrozen.org>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Mon, Jul 11, 2016 at 02:29:39PM +0200, John Crispin wrote:
> +static const struct of_device_id mt6323_of_match[] = {
> + { .compatible = "mediatek,mt6323-regulator", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, mt6323_of_match);
This may have been answered last time but I don't remember - why is
there a compatible string for this device in the DT? Surely we already
know that the regulators for the mt6323 are present by virtue of the
fact that we know that the core mt6323 is present in the system?
Indeed, looking at the now merged MFD code it appears that this is
in fact the case so we could just not have a compatible and perhaps this
was just an oversight. This is good because it means we're not encoding
the specific way Linux instantiates devices into the DT.
Otherwise this does look good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-11 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 12:29 [PATCH V8 1/2] regulator: Add document for MT6323 regulator John Crispin
2016-07-11 12:29 ` [PATCH V8 2/2] regulator: mt6323: Add support " John Crispin
2016-07-11 21:12 ` Mark Brown [this message]
[not found] ` <1468240179-7558-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2016-07-11 18:08 ` [PATCH V8 1/2] regulator: Add document " Mark Brown
2016-07-11 18:55 ` John Crispin
[not found] ` <cef78bd8-9a4a-e848-d7cb-13a27127f11e-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2016-07-11 19:22 ` Mark Brown
2016-07-11 20:31 ` John Crispin
2016-07-11 21:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711211235.GB9976@sirena.org.uk \
--to=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=john@phrozen.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox