From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [patch] drm/mediatek/mtk_mipi_tx: checking the wrong variable Date: Tue, 12 Jul 2016 14:47:27 +0200 Message-ID: <20160712124727.GX23520@phenom.ffwll.local> References: <20160701135934.GA15723@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: kernel-janitors-owner@vger.kernel.org To: Matthias Brugger Cc: Dan Carpenter , David Airlie , CK Hu , linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, Jitao Shi , dri-devel@lists.freedesktop.org List-Id: linux-mediatek@lists.infradead.org On Sat, Jul 02, 2016 at 06:44:13PM +0200, Matthias Brugger wrote: > > > On 07/01/2016 03:59 PM, Dan Carpenter wrote: > > We should be checking "phy_provider" here not "phy". > > > > Fixes: 2e54c14e310f ('drm/mediatek: Add DSI sub driver') > > Signed-off-by: Dan Carpenter > > > > Reviewed-by: Matthias Brugger Applied to drm-misc, thanks. -Daniel > > > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > > index cf8f38d..1c366f8 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > > +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > > @@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev) > > phy_set_drvdata(phy, mipi_tx); > > > > phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > > - if (IS_ERR(phy)) { > > + if (IS_ERR(phy_provider)) { > > ret = PTR_ERR(phy_provider); > > return ret; > > } > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch