From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v5 0/2] mtd: nand: fix writing incorrect ECC parity data in OOB region Date: Mon, 19 Sep 2016 11:47:58 +0200 Message-ID: <20160919114758.37ec6606@bbrezillon> References: <1474253606-9965-1-git-send-email-rogercc.lin@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1474253606-9965-1-git-send-email-rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: RogerCC Lin Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, steven.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Mon, 19 Sep 2016 10:53:24 +0800 RogerCC Lin wrote: > From: RogerCC Lin > > This series fix chances to write incorrect ECC data which may cause uncorrectable ECC error when reading. Applied (I'll send a PR to Brian). Thanks, Boris > > change since v4: > - use (i / 4) instead of (i >> 2) to make code more clear. > > changes since v3: > - use macro for function arguments. > > changes since v2: > - use macro for shift operation. > > changes since v1: > - separate patches into 2. > - use shift operator with byte access to avoid endianness conversion problems. > - follow linux coding style. > > The patch passed the test of UBIFS file-system read/write on Mediatek's RFB. The tested driver is checked-out from LEDE OpenWRT project's upstream driver, which is pretty much same as nand/next branch upstream driver(git clone https://git.lede-project.org/source.git). > > > RogerCC Lin (2): > mtd: nand: fix generating over-boundary ECC data when writing > mtd: nand: fix chances to create incomplete ECC data when writing > > drivers/mtd/nand/mtk_ecc.c | 12 ++++++++---- > drivers/mtd/nand/mtk_nand.c | 7 +++++-- > 2 files changed, 13 insertions(+), 6 deletions(-) >