From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] clk: mediatek: Fix MT2701 dependencies Date: Tue, 10 Jan 2017 13:03:00 +0100 Message-ID: <20170110130300.167d215b@endymion> References: <20170109113621.31d384c9@endymion> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-clk-owner@vger.kernel.org To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , James Liao , Erin Lo , Stephen Boyd , Shunli Wang , Michael Turquette List-Id: linux-mediatek@lists.infradead.org On Mon, 9 Jan 2017 21:08:50 +0100, Andreas Färber wrote: > Hi Jean, > > Am 09.01.2017 um 11:36 schrieb Jean Delvare: > > If I say "no" to "Clock driver for Mediatek MT2701", I don't want to > > be asked individually about each sub-driver. No means no. > > > > Additionally, this driver shouldn't be proposed at all on non-mediatek > > builds, unless build-testing. > > > > Signed-off-by: Jean Delvare > > Fixes: e9862118272a ("clk: mediatek: Add MT2701 clock support") > > Cc: Shunli Wang > > Cc: James Liao > > Cc: Erin Lo > > Cc: Stephen Boyd > > Cc: Michael Turquette > > Cc: Matthias Brugger > > --- > [...] > > As another side note, I wonder why so many clock drivers have > > "COMMON" in their symbol names. Looks wrong to me. > > It refers to the Common Clock Framework: > https://www.kernel.org/doc/Documentation/clk.txt OK, thanks for the explanation. Still seems overkill to me to prefix everything with COMMON_CLK when the drivers live under drivers/clk, but oh well :-) > > --- linux-4.10-rc2.orig/drivers/clk/mediatek/Kconfig 2017-01-01 23:31:53.000000000 +0100 > > +++ linux-4.10-rc2/drivers/clk/mediatek/Kconfig 2017-01-09 11:17:37.542344083 +0100 > > @@ -8,6 +8,7 @@ config COMMON_CLK_MEDIATEK > > > > config COMMON_CLK_MT2701 > > bool "Clock driver for Mediatek MT2701" > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > select COMMON_CLK_MEDIATEK > > default ARCH_MEDIATEK > > Should the default then become y for simplicity? I left it as is as it is the same already done in other drivers in the same directory. I agree "default y" would do the same in practice. > Another aspect here is that this is a 32-bit SoC but it propagates into > the arm64 configs, so maybe (ARCH_MEDIATEK && !ARM64) || COMPILE_TEST? > > Same for mt2701 pinctrl. > > http://kernel.opensuse.org/cgit/kernel-source/plain/config/arm64/default?id=ff90e915117c5d7a8bb00dc0bc1d3145ebe985ec Actually I thought the driver was needed primarily on arm64 because of this configuration file. If that's not the case then I can resubmit with the suggested change, no problem. What about MT8135 and MT8173, are they 32-bit SoCs as well? > (...) > Anyway, a step forward, > > Reviewed-by: Andreas Färber Thanks for the review. -- Jean Delvare SUSE L3 Support