public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: "James Liao" <jamesjj.liao@mediatek.com>,
	"Erin Lo" <erin.lo@mediatek.com>,
	"Stephen Boyd" <sboyd@codeaurora.org>,
	linux-clk@vger.kernel.org,
	"Michael Turquette" <mturquette@baylibre.com>,
	linux-mediatek@lists.infradead.org,
	"Shunli Wang" <shunli.wang@mediatek.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [PATCH] clk: mediatek: Fix MT2701 dependencies
Date: Wed, 11 Jan 2017 15:42:20 +0100	[thread overview]
Message-ID: <20170111154220.2d4c9da7@endymion> (raw)
In-Reply-To: <1484143526.8614.0.camel@mtksdaap41>

Hi Joe,

On Wed, 11 Jan 2017 22:05:26 +0800, Yingjoe Chen wrote:
> On Wed, 2017-01-11 at 13:41 +0100, Jean Delvare wrote:
> > @@ -52,16 +52,16 @@ config COMMON_CLK_MT2701_BDPSYS
> >  
> >  config COMMON_CLK_MT8135
> >  	bool "Clock driver for Mediatek MT8135"
> > -	depends on ARCH_MEDIATEK || COMPILE_TEST
> > +	depends on (ARCH_MEDIATEK && !ARM64) || COMPILE_TEST
> 
> 
> Why not just check for ARM?
> 
> +	depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST

I don't know :D Andreas suggested it for MT2701, so I assumed ARM was
set also for 64-bit kernels (like X86 is set for 64-bit kernels) and
ARM64 had to be used to differentiate. But it seems ARM isn't set for
64-bit kernels, so you are right, checking for ARM should work and is
more straightforward. I'll fix it before submitting the patch.

Thanks for the review,
-- 
Jean Delvare
SUSE L3 Support

  reply	other threads:[~2017-01-11 14:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 10:36 [PATCH] clk: mediatek: Fix MT2701 dependencies Jean Delvare
2017-01-09 20:08 ` Andreas Färber
2017-01-10 12:03   ` Jean Delvare
2017-01-11  1:56     ` James Liao
2017-01-11 12:41       ` Jean Delvare
2017-01-11 14:05         ` Yingjoe Chen
2017-01-11 14:42           ` Jean Delvare [this message]
2017-01-12  3:39         ` James Liao
2017-01-12  8:40           ` Jean Delvare
2017-01-20 23:22             ` Stephen Boyd
2017-01-24  9:46               ` Jean Delvare
2017-01-24 12:58   ` Jean Delvare
2017-01-10  2:32 ` James Liao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170111154220.2d4c9da7@endymion \
    --to=jdelvare@suse.de \
    --cc=afaerber@suse.de \
    --cc=erin.lo@mediatek.com \
    --cc=jamesjj.liao@mediatek.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=shunli.wang@mediatek.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox