From: Rob Herring <robh@kernel.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Guochun Mao <guochun.mao@mediatek.com>,
Richard Weinberger <richard@nod.at>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings
Date: Wed, 18 Jan 2017 16:08:09 -0600 [thread overview]
Message-ID: <20170118220809.pmaa2f3kwiddehti@rob-hp-laptop> (raw)
In-Reply-To: <20170113151326.11e9451a@bbrezillon>
On Fri, Jan 13, 2017 at 03:13:26PM +0100, Boris Brezillon wrote:
> On Fri, 13 Jan 2017 15:13:28 +0800
> Guochun Mao <guochun.mao@mediatek.com> wrote:
>
> > Add "mediatek,mt2701-nor" for nor flash node's compatible.
> >
> > Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> > ---
> > .../devicetree/bindings/mtd/mtk-quadspi.txt | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > index fb314f0..f83d31d 100644
> > --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > @@ -1,7 +1,9 @@
> > * Serial NOR flash controller for MTK MT81xx (and similar)
> >
> > Required properties:
> > -- compatible: should be "mediatek,mt8173-nor";
> > +- compatible: should contain:
> > + "mediatek,mt2701-nor" for MT2701,
> > + "mediatek,mt8173-nor" for MT8173.
>
> Do you need to define a new compatible? If the IPs are exactly the same
> in both SoCs it shouldn't be needed.
Rather the 2701 should contain both strings in that case.
Rob
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2017-01-18 22:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 7:13 [PATCH v1 0/2] add nor flash node for mt2701 Guochun Mao
2017-01-13 7:13 ` [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings Guochun Mao
[not found] ` <1484291609-20195-2-git-send-email-guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-01-13 14:13 ` Boris Brezillon
2017-01-18 22:08 ` Rob Herring [this message]
[not found] ` <1484291609-20195-1-git-send-email-guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-01-13 7:13 ` [PATCH v1 2/2] arm: dts: mt2701: add nor flash node Guochun Mao
[not found] ` <1484291609-20195-3-git-send-email-guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-01-13 12:49 ` Marek Vasut
2017-01-13 14:17 ` Boris Brezillon
2017-01-13 15:12 ` Matthias Brugger
2017-01-13 15:21 ` Boris Brezillon
[not found] ` <d7b866ad-5b2f-62d3-3aa3-6fa42803d625-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-13 16:13 ` Marek Vasut
2017-01-13 16:28 ` Boris Brezillon
2017-01-13 16:44 ` Marek Vasut
[not found] ` <86c997be-f500-eaa1-3ba5-d21cff6223b7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-13 16:56 ` Boris Brezillon
2017-01-13 17:33 ` Marek Vasut
[not found] ` <0fafcd8d-cf99-de6b-728f-5e3637810b68-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-14 8:29 ` Boris Brezillon
2017-01-15 0:23 ` Marek Vasut
[not found] ` <e7fa1542-f0e2-0e45-23b3-25d6491ae40d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-16 8:40 ` Boris Brezillon
2017-01-16 16:09 ` Marek Vasut
2017-01-17 3:36 ` Thomas Petazzoni
[not found] ` <20170117143650.5db87148-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-01-18 22:20 ` Rob Herring
2017-01-18 23:38 ` Thomas Petazzoni
2017-01-19 2:51 ` Rob Herring
[not found] ` <CAL_Jsq+EyHtC7THLCJcwgtVtVESMOdmi3T3bBxgOqJt6BCtCHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-19 8:14 ` Boris Brezillon
2017-01-19 14:18 ` Rob Herring
[not found] ` <CAL_Jsq+S-FYy4SmjJ3fWzBugw2zCj5TQkkfUA8QVL7SLJW3E1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-22 2:36 ` Guochun Mao
2017-01-24 10:31 ` Boris Brezillon
2017-01-24 10:38 ` John Crispin
2017-01-19 7:53 ` Boris Brezillon
2017-01-17 3:32 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118220809.pmaa2f3kwiddehti@rob-hp-laptop \
--to=robh@kernel.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=guochun.mao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox