From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2 Date: Fri, 2 Jun 2017 09:14:44 +0200 Message-ID: <20170602091444.1f1e1d1d@bbrezillon> References: <1496307679-16245-1-git-send-email-xiaolei.li@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1496307679-16245-1-git-send-email-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Thu, 1 Jun 2017 17:01:19 +0800 wrote: > From: Xiaolei Li > > Write size in function write_eraseblock2 is subpgsize * k. > It is wrong to check whether written is equal to subpgsize after each > mtd_write. > > Signed-off-by: Xiaolei Li Acked-by: Boris Brezillon > --- > drivers/mtd/tests/subpagetest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/tests/subpagetest.c b/drivers/mtd/tests/subpagetest.c > index aecc6ce..fa2519a 100644 > --- a/drivers/mtd/tests/subpagetest.c > +++ b/drivers/mtd/tests/subpagetest.c > @@ -102,7 +102,7 @@ static int write_eraseblock2(int ebnum) > if (unlikely(err || written != subpgsize * k)) { > pr_err("error: write failed at %#llx\n", > (long long)addr); > - if (written != subpgsize) { > + if (written != subpgsize * k) { > pr_err(" write size: %#x\n", > subpgsize * k); > pr_err(" written: %#08zx\n",