From: David Miller <davem@davemloft.net>
To: john@phrozen.org
Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
f.fainelli@gmail.com, sean.wang@mediatek.com,
netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, muciri@openmesh.com,
shashidhar.lakkavalli@openmesh.com
Subject: Re: [PATCH 0/4] net-next: dsa: fix flow dissection
Date: Wed, 09 Aug 2017 22:52:43 -0700 (PDT) [thread overview]
Message-ID: <20170809.225243.2204411285392662424.davem@davemloft.net> (raw)
In-Reply-To: <20170809124119.24320-1-john@phrozen.org>
From: John Crispin <john@phrozen.org>
Date: Wed, 9 Aug 2017 14:41:15 +0200
> RPS and probably other kernel features are currently broken on some if not
> all DSA devices. The root cause of this is that skb_hash will call the
> flow_dissector. At this point the skb still contains the magic switch
> header and the skb->protocol field is not set up to the correct 802.3
> value yet. By the time the tag specific code is called, removing the header
> and properly setting the protocol an invalid hash is already set. In the
> case of the mt7530 this will result in all flows always having the same
> hash.
>
> Changes since RFC:
> * use a callback instead of static values
> * add cover letter
Series applied, thanks.
next prev parent reply other threads:[~2017-08-10 5:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 12:41 [PATCH 0/4] net-next: dsa: fix flow dissection John Crispin
2017-08-09 12:41 ` [PATCH 1/4] net-next: dsa: move struct dsa_device_ops to the global header file John Crispin
[not found] ` <20170809124119.24320-2-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2017-08-09 13:45 ` Andrew Lunn
2017-08-09 12:41 ` [PATCH 3/4] net-next: tag_mtk: add flow_dissect callback to the ops struct John Crispin
2017-08-09 13:54 ` Andrew Lunn
[not found] ` <20170809124119.24320-1-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2017-08-09 12:41 ` [PATCH 2/4] net-next: dsa: add flow_dissect callback to struct dsa_device_ops John Crispin
[not found] ` <20170809124119.24320-3-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2017-08-09 13:51 ` Andrew Lunn
2017-08-09 12:41 ` [PATCH 4/4] net-next: dsa: fix flow dissection John Crispin
[not found] ` <20170809124119.24320-5-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2017-08-09 13:55 ` Andrew Lunn
2017-08-09 15:07 ` [PATCH 0/4] " Vivien Didelot
2017-08-10 5:52 ` David Miller [this message]
2017-08-10 6:42 ` Eric Dumazet
2017-08-10 7:40 ` John Crispin
2017-08-10 8:10 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809.225243.2204411285392662424.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=muciri@openmesh.com \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=shashidhar.lakkavalli@openmesh.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox