From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 4/4] net-next: dsa: fix flow dissection Date: Wed, 9 Aug 2017 15:55:08 +0200 Message-ID: <20170809135508.GF30723@lunn.ch> References: <20170809124119.24320-1-john@phrozen.org> <20170809124119.24320-5-john@phrozen.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170809124119.24320-5-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: John Crispin Cc: Florian Fainelli , Muciri Gatimu , Vivien Didelot , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sean Wang , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Shashidhar Lakkavalli , "David S . Miller" List-Id: linux-mediatek@lists.infradead.org On Wed, Aug 09, 2017 at 02:41:19PM +0200, John Crispin wrote: > RPS and probably other kernel features are currently broken on some if not > all DSA devices. The root cause of this is that skb_hash will call the > flow_dissector. At this point the skb still contains the magic switch > header and the skb->protocol field is not set up to the correct 802.3 > value yet. By the time the tag specific code is called, removing the header > and properly setting the protocol an invalid hash is already set. In the > case of the mt7530 this will result in all flows always having the same > hash. > > Signed-off-by: Muciri Gatimu > Signed-off-by: Shashidhar Lakkavalli > Signed-off-by: John Crispin Reviewed-by: Andrew Lunn Andrew