From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v1 1/2] mtd: nand: mtk: do not disable ECC IRQ in the function mtk_ecc_disable Date: Fri, 27 Oct 2017 14:45:38 +0200 Message-ID: <20171027144538.4875953f@bbrezillon> References: <1508746897-62291-1-git-send-email-xiaolei.li@mediatek.com> <1508746897-62291-2-git-send-email-xiaolei.li@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1508746897-62291-2-git-send-email-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Xiaolei Li Cc: srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Mon, 23 Oct 2017 16:21:36 +0800 Xiaolei Li wrote: > There will disable ECC IRQ in ECC IRQ handle function, so no need to > disable it again in the function mtk_ecc_disable. > > Signed-off-by: Xiaolei Li > --- > drivers/mtd/nand/mtk_ecc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c > index 7f3b065..82aa6f2 100644 > --- a/drivers/mtd/nand/mtk_ecc.c > +++ b/drivers/mtd/nand/mtk_ecc.c > @@ -307,7 +307,6 @@ void mtk_ecc_disable(struct mtk_ecc *ecc) > > /* disable it */ > mtk_ecc_wait_idle(ecc, op); > - writew(0, ecc->regs + ECC_IRQ_REG(op)); As explained in my review of patch 2, I would do it the other way around: remove this write from the irq handler and keep it here. > writew(ECC_OP_DISABLE, ecc->regs + ECC_CTL_REG(op)); > > mutex_unlock(&ecc->lock);