From: Jean Delvare <jdelvare@suse.de>
To: Sean Wang <sean.wang@mediatek.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
mturquette@baylibre.com, matthias.bgg@gmail.com,
jamesjj.liao@mediatek.com, weiyi.lu@mediatek.com, arnd@arndb.de,
linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: mediatek: remove unnecessary include header from reset.c
Date: Wed, 27 Dec 2017 13:15:50 +0100 [thread overview]
Message-ID: <20171227131550.2c65c6ff@endymion> (raw)
In-Reply-To: <1514345580.30687.27.camel@mtkswgap22>
Hi Sean, Stephen,
On Wed, 27 Dec 2017 11:33:00 +0800, Sean Wang wrote:
> On Tue, 2017-12-26 at 17:10 -0800, Stephen Boyd wrote:
> > drivers/clk/mediatek/reset.c:64:6: warning: symbol 'mtk_register_reset_controller' was not declared. Should it be static?
>
> It cannot be static since the function would be referenced in other
> files under the same folder
>
>
> One point I felt confused which is I didn't see the warning complains
> when I did these build test, even I also added -Werror and -Wall to
> build all files under driver/clk/mediatek. My toolchain is based on gcc
> version 5.2.0 (GCC).
I tested and I get the warning here (gcc 4.8.5 on SUSE) but only after
setting CONFIG_RESET_CONTROLLER=y. Without it,
drivers/clk/mediatek/reset.o is never built, so no warning can be
generated.
> If the warning still is, the include "clk-mtk.h" should be good to stay
> there because the declaration it needs is in the clk-mtk.h
Agreed.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-12-27 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 8:31 [PATCH] clk: mediatek: remove unnecessary include header from reset.c sean.wang
2017-12-27 1:10 ` Stephen Boyd
2017-12-27 3:33 ` Sean Wang
2017-12-27 12:15 ` Jean Delvare [this message]
2017-12-27 17:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227131550.2c65c6ff@endymion \
--to=jdelvare@suse.de \
--cc=arnd@arndb.de \
--cc=jamesjj.liao@mediatek.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=sean.wang@mediatek.com \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).