Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Srinivas Kandagatla
	<srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Andrey Smirnov
	<andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Masahiro Yamada
	<yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
	cphealy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: [PATCH v3 02/22] nvmem: core: Allow specifying device name verbatim
Date: Wed,  3 Jan 2018 12:00:54 -0800	[thread overview]
Message-ID: <20180103200114.23922-3-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180103200114.23922-1-andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Add code to allow avoid having nvmem core append a numeric suffix to
the end of the name by passing config->id of -1.

Cc: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
Cc: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
Cc: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Cc: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: cphealy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Signed-off-by: Andrey Smirnov <andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/nvmem/core.c           | 11 ++++++++---
 include/linux/nvmem-provider.h |  3 +++
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 5a5cefd12153..57cbeacfbeb2 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -475,9 +475,14 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
 	nvmem->reg_write = config->reg_write;
 	np = config->dev->of_node;
 	nvmem->dev.of_node = np;
-	dev_set_name(&nvmem->dev, "%s%d",
-		     config->name ? : "nvmem",
-		     config->name ? config->id : nvmem->id);
+
+	if (config->id == -1 && config->name) {
+		dev_set_name(&nvmem->dev, "%s", config->name);
+	} else {
+		dev_set_name(&nvmem->dev, "%s%d",
+			     config->name ? : "nvmem",
+			     config->name ? config->id : nvmem->id);
+	}
 
 	nvmem->read_only = of_property_read_bool(np, "read-only") |
 			   config->read_only;
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 27e599222ec1..4889a6c62a81 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -43,6 +43,9 @@ typedef int (*nvmem_reg_write_t)(void *priv, unsigned int offset,
  * Note: A default "nvmem<id>" name will be assigned to the device if
  * no name is specified in its configuration. In such case "<id>" is
  * generated with ida_simple_get() and provided id field is ignored.
+ *
+ * Note: Specifying name and setting id to -1 implies a unique device
+ * whose name is provided as-is (kept unaltered).
  */
 struct nvmem_config {
 	struct device		*dev;
-- 
2.14.3

  parent reply	other threads:[~2018-01-03 20:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 20:00 [PATCH v3 00/22] Verbatim device names and devm_nvmem_(un)register() Andrey Smirnov
2018-01-03 20:00 ` [PATCH v3 01/22] nvmem: Document struct nvmem_config Andrey Smirnov
2018-02-28 18:34   ` Sean Wang
2018-03-08 18:22     ` Andrey Smirnov
     [not found] ` <20180103200114.23922-1-andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-03 20:00   ` Andrey Smirnov [this message]
2018-01-03 20:00   ` [PATCH v3 03/22] nvmem: Introduce devm_nvmem_(un)register() Andrey Smirnov
2018-01-03 20:00   ` [PATCH v3 04/22] nvmem: vf610-ocotp: Convert to use devm_nvmem_register() Andrey Smirnov
2018-01-03 20:00   ` [PATCH v3 05/22] nvmem: imx-ocotp: " Andrey Smirnov
2018-01-03 20:00   ` [PATCH v3 06/22] nvmem: uniphier-efuse: " Andrey Smirnov
2018-01-03 20:00   ` [PATCH v3 07/22] nvmem: snvs_lgpr: " Andrey Smirnov
2018-01-03 20:01   ` [PATCH v3 10/22] nvmem: mtk-efuse: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 08/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 09/22] nvmem: qfprom: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 11/22] nvmem: meson-mx-efuse: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 12/22] nvmem: meson-efuse: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 13/22] nvmem: lpc18xx_otp: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 14/22] nvmem: imx-iim: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 15/22] nvmem: bcm-ocotp: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 16/22] nvmem: meson-efuse: Do no gate COMPILE_TEST with MESON_SM Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 17/22] nvmem: snvs_lpgpr: Convert commas to semicolons Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 18/22] nvmem: rockchip-efuse: Make use of of_device_get_match_data() Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 19/22] nvmem: vf610-ocotp: Do not use "&pdev->dev" explicitly Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 20/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 21/22] nvmem: imx-iim: " Andrey Smirnov
2018-01-03 20:01 ` [PATCH v3 22/22] nvmem: bcm-ocotp: " Andrey Smirnov
2018-01-24 11:13 ` [PATCH v3 00/22] Verbatim device names and devm_nvmem_(un)register() Bartosz Golaszewski
     [not found]   ` <CAMRc=Mct60LMcr-CGJue1dTK+XNwz=dmkm2arTGeN1czeN9JoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-25  9:17     ` Srinivas Kandagatla
2018-02-26  3:45       ` Andrey Smirnov
2018-02-26  9:30         ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180103200114.23922-3-andrew.smirnov@gmail.com \
    --to=andrew.smirnov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org \
    --cc=cphealy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox