From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Coffey Subject: [PATCH] staging: mt7621-eth: Fix sparse warning in ethtool.c Date: Wed, 28 Mar 2018 22:18:48 +0100 Message-ID: <20180328211848.11085-1-cmc@babblebit.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Greg Kroah-Hartman , NeilBrown , Matthias Brugger Cc: devel@driverdev.osuosl.org, Chris Coffey , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org Include the local ethtool.h header file in mtk_eth_soc.h so implementation files have centralized access to it. This fixes the following sparse warning: drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol 'mtk_set_ethtool_ops' was not declared. Should it be static? Signed-off-by: Chris Coffey --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 1 - drivers/staging/mt7621-eth/mtk_eth_soc.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth/mtk_eth_soc.c index cbc7339843..0574e71573 100644 --- a/drivers/staging/mt7621-eth/mtk_eth_soc.c +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.c @@ -35,7 +35,6 @@ #include "mtk_eth_soc.h" #include "mdio.h" -#include "ethtool.h" #define MAX_RX_LENGTH 1536 #define MTK_RX_ETH_HLEN (VLAN_ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.h b/drivers/staging/mt7621-eth/mtk_eth_soc.h index 443f88d8af..01deeddfdd 100644 --- a/drivers/staging/mt7621-eth/mtk_eth_soc.h +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.h @@ -23,6 +23,7 @@ #include #include #include +#include "ethtool.h" /* these registers have different offsets depending on the SoC. we use a lookup * table for these -- 2.11.0