From: Mark Brown <broonie@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: alsa-devel@alsa-project.org, ryder.lee@mediatek.com,
wsd_upstream@mediatek.com, chipeng.chang@mediatek.com,
garlic.tseng@mediatek.com, linux-mediatek@lists.infradead.org,
KaiChieh Chuang <kaichieh.chuang@mediatek.com>
Subject: Re: [PATCH] ASoC: mt6797: switch to SPDX license tag
Date: Thu, 26 Apr 2018 12:42:44 +0100 [thread overview]
Message-ID: <20180426114244.GD21755@sirena.org.uk> (raw)
In-Reply-To: <7071d4e1-daf1-4847-1dbd-e5c77c709724@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 956 bytes --]
On Thu, Apr 26, 2018 at 12:46:54PM +0200, Matthias Brugger wrote:
> On 04/26/2018 04:56 AM, KaiChieh Chuang wrote:
> > diff --git a/sound/soc/mediatek/mt6797/mt6797-mt6351.c b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > index d42a9d9fbf3e..c3f58bac0960 100644
> > --- a/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > +++ b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
> > @@ -1,17 +1,9 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > /*
> > * mt6797-mt6351.c -- MT6797 MT6351 ALSA SoC machine driver
> > *
Please convert the entire header block to a C++ comment so it looks more
intentional that it's this way.
> > - * Author: Ryder Lee <ryder.lee@mediatek.com>
> > + * Author: KaiChieh Chuang <kaichieh.chuang@mediatek.com>
> I think you don't want to delete the first author but add you as a second one.
> I've seen this in other parts of the patch as well. Please check.
Yeah, looks like an over eager removal of the license text boiler
plate.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-04-26 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 2:56 [PATCH] ASoC: mt6797: switch to SPDX license tag KaiChieh Chuang
2018-04-26 10:46 ` Matthias Brugger
2018-04-26 11:42 ` Mark Brown [this message]
2018-04-27 1:56 ` Ryder Lee
2018-04-27 2:03 ` Garlic Tseng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426114244.GD21755@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=chipeng.chang@mediatek.com \
--cc=garlic.tseng@mediatek.com \
--cc=kaichieh.chuang@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ryder.lee@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox