Re: [PATCH 1/2] ASoC: add documents for mt6351

[Rob Herring <robh@kernel.org>]

On Thu, Apr 26, 2018 at 11:07:31AM +0800, KaiChieh Chuang wrote:
> Signed-off-by: KaiChieh Chuang <kaichieh.chuang@mediatek.com>

Needs a commit msg and 'binding' would be more informative than 
'documents' in the subject.

> ---
>  Documentation/devicetree/bindings/sound/mt6351.txt | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/mt6351.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/mt6351.txt b/Documentation/devicetree/bindings/sound/mt6351.txt
> new file mode 100644
> index 000000000000..7fb2cb99245e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mt6351.txt
> @@ -0,0 +1,16 @@
> +Mediatek MT6351 Audio Codec
> +
> +The communication between MT6351 and SoC is through Mediatek PMIC wrapper.
> +For more detail, please visit Mediatek PMIC wrapper documentation.

Add the path to the doc file.

What's a wrapper? Is this a block within the PMIC or ?

> +
> +Must be a child node of PMIC wrapper.
> +
> +Required properties:
> +
> +- compatible : "mediatek,mt6351-sound".
> +
> +Example:
> +
> +mt6351_snd {
> +	compatible = "mediatek,mt6351-sound";
> +};
> -- 
> 2.12.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html