From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [v3 03/10] mfd: mtk-mmsys: Add mmsys driver Date: Wed, 4 Jul 2018 17:45:40 +0100 Message-ID: <20180704164540.GH496@dell> References: <20180430101826.GC5147@dell> <5269ccfd-0274-3c12-7eeb-5de923197d92@gmail.com> <20180703071103.GE20176@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Matthias Brugger Cc: mark.rutland@arm.com, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, linux-clk@vger.kernel.org, linux@armlinux.org.uk, sean.wang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, rdunlap@infradead.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, matthias.bgg@kernel.org, davem@davemloft.net List-Id: linux-mediatek@lists.infradead.org T24gV2VkLCAwNCBKdWwgMjAxOCwgTWF0dGhpYXMgQnJ1Z2dlciB3cm90ZToKCj4gCj4gCj4gT24g MDMvMDcvMTggMDk6MTEsIExlZSBKb25lcyB3cm90ZToKPiA+IE9uIE1vbiwgMjUgSnVuIDIwMTgs IE1hdHRoaWFzIEJydWdnZXIgd3JvdGU6Cj4gPj4gT24gMzAvMDQvMTggMTI6MTgsIExlZSBKb25l cyB3cm90ZToKPiA+Pj4gT24gRnJpLCAyNyBBcHIgMjAxOCwgbWF0dGhpYXMuYmdnQGtlcm5lbC5v cmcgd3JvdGU6Cj4gPj4+Cj4gPj4+PiBGcm9tOiBNYXR0aGlhcyBCcnVnZ2VyIDxtYnJ1Z2dlckBz dXNlLmNvbT4KPiA+Pj4+Cj4gPj4+PiBUaGUgTU1TWVMgc3Vic3lzdGVtIGluY2x1ZGVzIGNsb2Nr cyBhbmQgZHJtIGNvbXBvbmVudHMuCj4gPj4+PiBUaGlzIHBhdGNoIGFkZHMgYSBNRkQgZGV2aWNl IHRvIHByb2JlIGJvdGggZHJpdmVycyBmcm9tIHRoZSBzYW1lCj4gPj4+PiBkZXZpY2UgdHJlZSBj b21wYXRpYmxlLgo+ID4+Pj4KPiA+Pj4+IFNpZ25lZC1vZmYtYnk6IE1hdHRoaWFzIEJydWdnZXIg PG1icnVnZ2VyQHN1c2UuY29tPgo+ID4+Pj4gLS0tCj4gPj4+PiAgZHJpdmVycy9tZmQvS2NvbmZp ZyAgICAgfCAgOSArKysrKysKPiA+Pj4+ICBkcml2ZXJzL21mZC9NYWtlZmlsZSAgICB8ICAyICsr Cj4gPj4+PiAgZHJpdmVycy9tZmQvbXRrLW1tc3lzLmMgfCA3OSArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPj4+PiAgMyBmaWxlcyBjaGFuZ2VkLCA5 MCBpbnNlcnRpb25zKCspCj4gPj4+PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWZkL210 ay1tbXN5cy5jCj4gPj4+Pgo+ID4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL0tjb25maWcg Yi9kcml2ZXJzL21mZC9LY29uZmlnCj4gPj4+PiBpbmRleCBiODYwZWI1YWExOTQuLmQyM2EzYjlh MmM1OCAxMDA2NDQKPiA+Pj4+IC0tLSBhL2RyaXZlcnMvbWZkL0tjb25maWcKPiA+Pj4+ICsrKyBi L2RyaXZlcnMvbWZkL0tjb25maWcKPiA+Pj4+IEBAIC0zNzgsNiArMzc4LDE1IEBAIGNvbmZpZyBN RkRfTUMxM1hYWF9JMkMKPiA+Pj4+ICAJaGVscAo+ID4+Pj4gIAkgIFNlbGVjdCB0aGlzIGlmIHlv dXIgTUMxM3h4eCBpcyBjb25uZWN0ZWQgdmlhIGFuIEkyQyBidXMuCj4gPj4+PiAgCj4gPj4+PiAr Y29uZmlnIE1GRF9NRURJQVRFS19NTVNZUwo+ID4+Pj4gKwl0cmlzdGF0ZSAiTWVkaWF0ZWsgTU1T WVMgaW50ZXJmYWNlIgo+ID4+Pj4gKwlzZWxlY3QgTUZEX0NPUkUKPiA+Pj4+ICsJc2VsZWN0IFJF R01BUF9NTUlPCj4gPj4+PiArCWhlbHAKPiA+Pj4+ICsJICBTZWxlY3QgdGhpcyBpZiB5b3UgaGF2 ZSBhIE1NU1lTIHN1YnN5c3RlbSBpbiB5b3VyIFNvQy4gVGhlCj4gPj4+PiArCSAgTU1TWVMgc3Vi c3lzdGVtIGhhcyBhdCBsZWFzdCBhIGNsb2NrIGRyaXZlciBwYXJ0IGFuZCBzb21lCj4gPj4+PiAr CSAgRFJNIGNvbXBvbmVudHMuCj4gPj4+PiArCj4gPj4+PiAgY29uZmlnIE1GRF9NWFNfTFJBREMK PiA+Pj4+ICAJdHJpc3RhdGUgIkZyZWVzY2FsZSBpLk1YMjMvaS5NWDI4IExSQURDIgo+ID4+Pj4g IAlkZXBlbmRzIG9uIEFSQ0hfTVhTIHx8IENPTVBJTEVfVEVTVAo+ID4+Pj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvbWZkL01ha2VmaWxlIGIvZHJpdmVycy9tZmQvTWFrZWZpbGUKPiA+Pj4+IGluZGV4 IGQ5ZDJjZjBkMzJlZi4uYjk2MTE4YmQ2OGQ5IDEwMDY0NAo+ID4+Pj4gLS0tIGEvZHJpdmVycy9t ZmQvTWFrZWZpbGUKPiA+Pj4+ICsrKyBiL2RyaXZlcnMvbWZkL01ha2VmaWxlCj4gPj4+PiBAQCAt OTgsNiArOTgsOCBAQCBvYmotJChDT05GSUdfTUZEX01DMTNYWFgpCSs9IG1jMTN4eHgtY29yZS5v Cj4gPj4+PiAgb2JqLSQoQ09ORklHX01GRF9NQzEzWFhYX1NQSSkJKz0gbWMxM3h4eC1zcGkubwo+ ID4+Pj4gIG9iai0kKENPTkZJR19NRkRfTUMxM1hYWF9JMkMpCSs9IG1jMTN4eHgtaTJjLm8KPiA+ Pj4+ICAKPiA+Pj4+ICtvYmotJChDT05GSUdfTUZEX01FRElBVEVLX01NU1lTKSArPSBtdGstbW1z eXMubwo+ID4+Pj4gKwo+ID4+Pj4gIG9iai0kKENPTkZJR19NRkRfQ09SRSkJCSs9IG1mZC1jb3Jl Lm8KPiA+Pj4+ICAKPiA+Pj4+ICBvYmotJChDT05GSUdfRVpYX1BDQVApCQkrPSBlengtcGNhcC5v Cj4gPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvbXRrLW1tc3lzLmMgYi9kcml2ZXJzL21m ZC9tdGstbW1zeXMuYwo+ID4+Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+Pj4+IGluZGV4IDAw MDAwMDAwMDAwMC4uYzgwMjM0M2ZiMWM2Cj4gPj4+PiAtLS0gL2Rldi9udWxsCj4gPj4+PiArKysg Yi9kcml2ZXJzL21mZC9tdGstbW1zeXMuYwo+ID4+Pj4gQEAgLTAsMCArMSw3OSBAQAo+ID4+Pj4g Ky8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wKwo+ID4+Pj4gKwo+ID4+Pj4gKy8q Cj4gPj4+PiArICogbXRrLW1tc3lzLmMgLS0gTWVkaWF0ZWsgTU1TWVMgbXVsdGktZnVuY3Rpb24g ZHJpdmVyCj4gPj4+PiArICoKPiA+Pj4+ICsgKiBDb3B5cmlnaHQgKGMpIDIwMTggTWF0dGhpYXMg QnJ1Z2dlciA8bWF0dGhpYXMuYmdnQGdtYWlsLmNvbT4KPiA+Pj4+ICsgKgo+ID4+Pj4gKyAqIEF1 dGhvcjogTWF0dGhpYXMgQnJ1Z2dlciA8bWF0dGhpYXMuYmdnQGdtYWlsLmNvbT4KPiA+Pj4+ICsg Ki8KPiA+Pj4+ICsKPiA+Pj4+ICsjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4gPj4+PiArI2lu Y2x1ZGUgPGxpbnV4L2luaXQuaD4KPiA+Pj4+ICsjaW5jbHVkZSA8bGludXgvbWZkL2NvcmUuaD4K PiA+Pj4+ICsjaW5jbHVkZSA8bGludXgvb2YuaD4KPiA+Pj4+ICsjaW5jbHVkZSA8bGludXgvb2Zf YWRkcmVzcy5oPgo+ID4+Pj4gKyNpbmNsdWRlIDxsaW51eC9vZl9kZXZpY2UuaD4KPiA+Pj4+ICsj aW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGV2aWNlLmg+Cj4gPj4+PiArI2luY2x1ZGUgPGxpbnV4 L3JlZ21hcC5oPgo+ID4+Pj4gKwo+ID4+Pj4gK2VudW0gewo+ID4+Pj4gKwlNTVNZU19NVDI3MDEg PSAxLAo+ID4+Pj4gK307Cj4gPj4+PiArCj4gPj4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBtZmRf Y2VsbCBtbXN5c19tdDI3MDFfZGV2c1tdID0gewo+ID4+Pj4gKwl7IC5uYW1lID0gImNsay1tdDI3 MDEtbW0iLCB9LAo+ID4+Pj4gKwl7IC5uYW1lID0gImRybS1tdDI3MDEtbW0iLCB9LAo+ID4+Pj4g K307Cj4gPj4+PiArCj4gPj4+PiArc3RhdGljIGludCBtbXN5c19wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQo+ID4+Pj4gK3sKPiA+Pj4+ICsJY29uc3Qgc3RydWN0IG1mZF9jZWxs ICptbXN5c19jZWxsczsKPiA+Pj4+ICsJaW50IG5yX2NlbGxzOwo+ID4+Pj4gKwlsb25nIGlkOwo+ ID4+Pj4gKwlpbnQgcmV0Owo+ID4+Pj4gKwo+ID4+Pj4gKwlpZCA9IChsb25nKSBvZl9kZXZpY2Vf Z2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7Cj4gPj4+PiArCWlmICghaWQpIHsKPiA+Pj4+ICsJ CWRldl9lcnIoJnBkZXYtPmRldiwgIm9mX2RldmljZV9nZXQgbWF0Y2hfZGF0YSgpIGZhaWxlZFxu Iik7Cj4gPj4+PiArCQlyZXR1cm4gLUVJTlZBTDsKPiA+Pj4+ICsJfQo+ID4+Pj4gKwo+ID4+Pj4g Kwlzd2l0Y2ggKGlkKSB7Cj4gPj4+PiArCWNhc2UgTU1TWVNfTVQyNzAxOgo+ID4+Pj4gKwkJbW1z eXNfY2VsbHMgPSBtbXN5c19tdDI3MDFfZGV2czsKPiA+Pj4+ICsJCW5yX2NlbGxzID0gQVJSQVlf U0laRShtbXN5c19tdDI3MDFfZGV2cyk7Cj4gPj4+PiArCQlicmVhazsKPiA+Pj4+ICsJZGVmYXVs dDoKPiA+Pj4+ICsJCXJldHVybiAtRU5PREVWOwo+ID4+Pj4gKwl9Cj4gPj4+PiArCj4gPj4+PiAr CXJldCA9IGRldm1fbWZkX2FkZF9kZXZpY2VzKCZwZGV2LT5kZXYsIDAsIG1tc3lzX2NlbGxzLCBu cl9jZWxscywKPiA+Pj4+ICsJCQkJCU5VTEwsIDAsIE5VTEwpOwo+ID4+Pj4gKwlpZiAocmV0KSB7 Cj4gPj4+PiArCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJmYWlsZWQgdG8gYWRkIE1GRCBkZXZpY2Vz ICVkXG4iLCByZXQpOwo+ID4+Pj4gKwkJcmV0dXJuIHJldDsKPiA+Pj4+ICsJfQo+ID4+Pj4gKwo+ ID4+Pj4gKwlyZXR1cm4gMDsKPiA+Pj4+ICt9Owo+ID4+Pgo+ID4+PiBUaGlzIGRyaXZlciBpcyBw cmV0dHkgcG9pbnRsZXNzLiAgSXQgZG9lc24ndCBhY3R1YWxseSBkbyBhbnl0aGluZy4KPiA+Pj4K PiA+Pj4gSSB0aGluayB5b3UganVzdCB3YW50IHRvIHVzZSAic2ltcGxlLW1mZCIgaW5zdGVhZC4K PiA+Pj4KPiA+Pgo+ID4+IEkgdGhpbmsgdGhlIHByb2JsZW0gaXMsIHRoYXQgcmlnaHQgbm93IHdl IGhhdmUgdHdvIGRyaXZlcnMgd2hpY2ggdXNlIHRoZSBzYW1lCj4gPj4gZGV2aWNldHJlZSBiaW5k aW5nLCB3aGljaCBhcmUgY2xrIGFuZCBkcm0gZHJpdmVyLiBXaXRoIGEgc2ltcGxlLW1mZCB3ZSB3 b3VsZAo+ID4+IG5lZWQgdHdvIGNvbXBhdGlibGVzLCBhbmQgdGhpcyB3b3VsZCBicmVhayBiYWNr d2FyZHMgY29tcGF0aWJpbGl0eS4KPiA+IAo+ID4gU28gd2hhdCBmdW5jdGlvbmFsaXR5IGRvZXMg dGhpcyBkcml2ZXIgcHJvdmlkZSB5b3Ugd2l0aCB0aGF0IHlvdSBkbwo+ID4gbm90IGhhdmUgY3Vy cmVudGx5Pwo+ID4gCj4gCj4gSSdtIG5vdCBzdXJlIGlmIEkgZ2V0IHlvdXIgcXVlc3Rpb24uIFBv aW50IGlzLCB0aGF0IHRoZSBNTVNZUyBpbXBsZW1lbnRhdGlvbiBmb3IKPiBtdDgxNzMgaXMgYnJv a2VuLCBhcyBpdCBhc3N1bWVzIHRoYXQgd2UgY2FuIHByb2JlIHR3byBkcml2ZXJzIHdpdGggdGhl Cj4gbWVkaWF0ZWssbXQ4MTczLW1tc3lzIGNvbXBhdGlibGUuIFNvbWVob3cgaXQgdXNlZCB0byB3 b3JrLCBidXQgZnJvbSB3aGF0IEkKPiB1bmRlcnN0YW5kIGl0IHdhcyBhIGJ1Zy4gU28gb2xkZXIg ZGV2aWNldHJlZXMgdXNlIGp1c3Qgb24gbXQ4MTczLW1tc3lzCj4gY29tcGF0aWJsZSBpbiB0aGVy IERUQi4KCk9rYXksIHRoYXQgaXMgd2hhdCBJIHdhcyBnZXR0aW5nIGF0LiAgVGhhbmtzIGZvciB0 aGUgZXhwbGFuYXRpb24uCgpEbyB5b3UgaGF2ZSBhIGRhdGFzaGVldCBJIGNhbiBsb29rIGF0PwoK PiBJIHdvdWxkIGxpa2UgdG8ga2VlcCBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eSBmb3IgdGhlIGRl dmljZSB0cmVlLCB0aGF0J3Mgd2h5IEkKPiB3YXMgc2VhcmNoaW5nIGZvciBhIHNvbHV0aW9uIHdo ZXJlIHdlIGNhbiBwcm9iZSB0d28gZHJpdmVycyBhbmQgY2FtZSB1cCB3aXRoCj4gdGhpcyBtZmQg c29sdXRpb24uCj4KPiBTbyBubyBuZXcgZnVuY3Rpb25hbGl0eSwgdGhlIGNsayBkcml2ZXIgcHJv dmlkZXMgdGhlIGNsb2NrIHRoZSBkcm0gY29tcG9uZW50cyBuZWVkLgoKLS0gCkxlZSBKb25lcyBb 5p2O55C85pavXQpMaW5hcm8gU2VydmljZXMgVGVjaG5pY2FsIExlYWQKTGluYXJvLm9yZyDilIIg T3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29r IHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==