public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>,
	Hans Ulli Kroll
	<ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
	Jakub Kicinski <kubakici-5tc4TXWwyLM@public.gmane.org>,
	Michal Schmidt <mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 00/11] Add mt76x0 driver
Date: Thu, 5 Jul 2018 17:32:17 +0200	[thread overview]
Message-ID: <20180705153216.GE17524@localhost.localdomain> (raw)
In-Reply-To: <1530771142-4118-1-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Jul 05, Stanislaw Gruszka wrote:
> Add mt76x0 driver for MT7610U based USB dongles. Currently driver
> support only STA mode.

Hi Stanislaw,

> 
> mt76x0 is based on Jakub's mt7601u driver already included
> in the kernel. I would like the driver be integrated as part
> of mt76 (instead of separate driver in mediatek dir like mt7601u)
> to utilize mt76 code for adding support for MT76x0 PCIe devices
> in further development.
> 
> To do not collide with current mt76x2u work from Lorenzo, I did not
> remove some code duplication. This will be done in the future, when
> Lorenzo patches will be merged. I plan to do more close integration
> with mt76x2u into common mt76 layer and add support for MT76x0 PCIe
> devices (i.e. MT7630E). Any help with this work is obviously welcome.
> My integration efforts can be traced here:
> https://github.com/sgruszka/wireless-drivers-next/commits/mt76x0-draft
> 

I just had a brief review of the code and I compiled the driver since at
the moment I had no adapter for that chipset.
As a remainder for future improvements/integration most of the code in 
dma.c, usb.c (except probe/disconnect functions) and tx.c can use the related
routines in the mt76-usb layer (we need to fill function pointer for chipset
related stuff if there are differences with mt76x2u, not looked yet).
Moreover mcu code can use utility routines in usb-mcu.c
I have not looked at mt76x2 common code yet.

Regards,
Lorenzo

> For full support mt7610.bin firmware blob is need, hopefully with 
> the permission of Mediatek, the blob will be pushed into linux-firmware
> git tree.
> 
> Stanislaw Gruszka (11):
>   mt76: add more states
>   mt76x0: core files
>   mt76x0: mac files
>   mt76x0: usb files
>   mt76x0: mcu files
>   mt76x0: phy files
>   mt76x0: init files
>   mt76x0: eeprom files
>   mt76x0: trace and debugfs files
>   mt76x0: dma and tx files
>   mt76: Kconfig and Makefile for mt76x0 driver
> 
>  drivers/net/wireless/mediatek/mt76/Kconfig         |    7 +
>  drivers/net/wireless/mediatek/mt76/Makefile        |    1 +
>  drivers/net/wireless/mediatek/mt76/mt76.h          |    4 +
>  drivers/net/wireless/mediatek/mt76/mt76x0/Makefile |    7 +
>  drivers/net/wireless/mediatek/mt76/mt76x0/core.c   |   34 +
>  .../net/wireless/mediatek/mt76/mt76x0/debugfs.c    |  166 ++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/dma.c    |  522 ++++++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/dma.h    |  126 +++
>  drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c |  445 +++++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.h |  149 +++
>  drivers/net/wireless/mediatek/mt76/mt76x0/init.c   |  720 ++++++++++++++
>  .../net/wireless/mediatek/mt76/mt76x0/initvals.h   |  282 ++++++
>  .../wireless/mediatek/mt76/mt76x0/initvals_phy.h   |  772 +++++++++++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/mac.c    |  661 +++++++++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/mac.h    |  154 +++
>  drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c    |  650 +++++++++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/mcu.h    |  101 ++
>  drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h |  376 ++++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/phy.c    | 1007 ++++++++++++++++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/phy.h    |   81 ++
>  drivers/net/wireless/mediatek/mt76/mt76x0/regs.h   |  651 +++++++++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/trace.c  |   21 +
>  drivers/net/wireless/mediatek/mt76/mt76x0/trace.h  |  366 +++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/tx.c     |  270 ++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/usb.c    |  377 ++++++++
>  drivers/net/wireless/mediatek/mt76/mt76x0/usb.h    |   61 ++
>  drivers/net/wireless/mediatek/mt76/mt76x0/util.c   |   42 +
>  27 files changed, 8053 insertions(+)
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/core.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/debugfs.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/dma.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/dma.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/init.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/initvals_phy.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/mac.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/mac.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/mcu.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/phy.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/regs.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/trace.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/trace.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/tx.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/usb.h
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/util.c
> 
> -- 
> 1.9.3
> 

  parent reply	other threads:[~2018-07-05 15:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  6:12 [PATCH 00/11] Add mt76x0 driver Stanislaw Gruszka
     [not found] ` <1530771142-4118-1-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05  6:12   ` [PATCH 01/11] mt76: add more states Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 02/11] mt76x0: core files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 03/11] mt76x0: mac files Stanislaw Gruszka
     [not found]     ` <1530771142-4118-4-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05 15:17       ` Lorenzo Bianconi
2018-07-05  6:12   ` [PATCH 04/11] mt76x0: usb files Stanislaw Gruszka
     [not found]     ` <1530771142-4118-5-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05 15:05       ` Lorenzo Bianconi
     [not found]         ` <20180705150519.GB17524-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-07-06 10:42           ` Stanislaw Gruszka
2018-07-23  6:38           ` Kalle Valo
     [not found]             ` <87va96tq1g.fsf-5ukZ45wKbUHoml4zekdYB16hYfS7NtTn@public.gmane.org>
2018-07-23  8:57               ` Lorenzo Bianconi
     [not found]                 ` <CAJ0CqmV_pPrKnRvcCrn-pUNGgJ9bDoFY+H2u0eokOayX7N08oA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-23  9:07                   ` Kalle Valo
     [not found]                     ` <87pnzexqul.fsf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-07-23  9:31                       ` Lorenzo Bianconi
2018-07-05  6:12   ` [PATCH 05/11] mt76x0: mcu files Stanislaw Gruszka
     [not found]     ` <1530771142-4118-6-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05 15:13       ` Lorenzo Bianconi
2018-07-05  6:12   ` [PATCH 06/11] mt76x0: phy files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 07/11] mt76x0: init files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 08/11] mt76x0: eeprom files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 09/11] mt76x0: trace and debugfs files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 10/11] mt76x0: dma and tx files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 11/11] mt76: Kconfig and Makefile for mt76x0 driver Stanislaw Gruszka
     [not found]     ` <1530771142-4118-12-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05  8:40       ` kbuild test robot
2018-07-05 14:50       ` Lorenzo Bianconi
     [not found]         ` <20180705145018.GA17524-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-07-06 10:32           ` Stanislaw Gruszka
2018-07-05 15:32   ` Lorenzo Bianconi [this message]
     [not found]     ` <20180705153216.GE17524-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-07-06 10:36       ` [PATCH 00/11] Add " Stanislaw Gruszka
     [not found]         ` <20180706103657.GB2033-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-06 11:37           ` Lorenzo Bianconi
2018-07-07  8:38       ` Hans Ulli Kroll
2018-07-20 10:30         ` Stanislaw Gruszka
     [not found]           ` <20180720103032.GA1791-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-20 10:36             ` Stanislaw Gruszka
2018-07-20 12:18             ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705153216.GE17524@localhost.localdomain \
    --to=lorenzo.bianconi-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=kubakici-5tc4TXWwyLM@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=nbd-Vt+b4OUoWG0@public.gmane.org \
    --cc=sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox