linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Stanislaw Gruszka
	<sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-wireless
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>,
	Hans Ulli Kroll
	<ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
	Jakub Kicinski <kubakici-5tc4TXWwyLM@public.gmane.org>,
	Michal Schmidt <mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 04/11] mt76x0: usb files
Date: Mon, 23 Jul 2018 11:31:37 +0200	[thread overview]
Message-ID: <20180723093136.GA17285@localhost.localdomain> (raw)
In-Reply-To: <87pnzexqul.fsf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

> Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
> 
> >>
> >> Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
> >>
> >> > On Jul 05, Stanislaw Gruszka wrote:
> >> >> Add usb files of mt76x0 driver.
> >> >>
> >> >> Signed-off-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >>
> >> [...]
> >>
> >> >> +static int mt76x0_suspend(struct usb_interface *usb_intf, pm_message_t state)
> >> >> +{
> >> >> +    struct mt76x0_dev *dev = usb_get_intfdata(usb_intf);
> >> >> +
> >> >> +    mt76x0_cleanup(dev);
> >> >
> >> > Is it necessary to deallocate rx queue here in case of a system suspend?
> >>
> >> BTW it would really helpful to others if you could edit your quotes. It
> >> takes some time to find your oneliner from a 450 line message.
> >
> > Ack sorry, I will be more verbose next time :).
> 
> I think you misunderstood, I actually was asking to be less verbose :)
> 
> The oneliner was just fine. I was just suggesting that instead of
> sending a message with 400 lines trim the unnecessary quotation and just
> send a shorter 50 line message. That way you save a lot of time (and
> avoid frustration) for the people reading your mail.

Ops, I completely misunderstood, will do next time sorry :)

Regards,
Lorenzo

> 
> -- 
> Kalle Valo

  parent reply	other threads:[~2018-07-23  9:31 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  6:12 [PATCH 00/11] Add mt76x0 driver Stanislaw Gruszka
     [not found] ` <1530771142-4118-1-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05  6:12   ` [PATCH 01/11] mt76: add more states Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 02/11] mt76x0: core files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 03/11] mt76x0: mac files Stanislaw Gruszka
     [not found]     ` <1530771142-4118-4-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05 15:17       ` Lorenzo Bianconi
2018-07-05  6:12   ` [PATCH 04/11] mt76x0: usb files Stanislaw Gruszka
     [not found]     ` <1530771142-4118-5-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05 15:05       ` Lorenzo Bianconi
     [not found]         ` <20180705150519.GB17524-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-07-06 10:42           ` Stanislaw Gruszka
2018-07-23  6:38           ` Kalle Valo
     [not found]             ` <87va96tq1g.fsf-5ukZ45wKbUHoml4zekdYB16hYfS7NtTn@public.gmane.org>
2018-07-23  8:57               ` Lorenzo Bianconi
     [not found]                 ` <CAJ0CqmV_pPrKnRvcCrn-pUNGgJ9bDoFY+H2u0eokOayX7N08oA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-23  9:07                   ` Kalle Valo
     [not found]                     ` <87pnzexqul.fsf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-07-23  9:31                       ` Lorenzo Bianconi [this message]
2018-07-05  6:12   ` [PATCH 05/11] mt76x0: mcu files Stanislaw Gruszka
     [not found]     ` <1530771142-4118-6-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05 15:13       ` Lorenzo Bianconi
2018-07-05  6:12   ` [PATCH 06/11] mt76x0: phy files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 07/11] mt76x0: init files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 08/11] mt76x0: eeprom files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 09/11] mt76x0: trace and debugfs files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 10/11] mt76x0: dma and tx files Stanislaw Gruszka
2018-07-05  6:12   ` [PATCH 11/11] mt76: Kconfig and Makefile for mt76x0 driver Stanislaw Gruszka
     [not found]     ` <1530771142-4118-12-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-05  8:40       ` kbuild test robot
2018-07-05 14:50       ` Lorenzo Bianconi
     [not found]         ` <20180705145018.GA17524-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-07-06 10:32           ` Stanislaw Gruszka
2018-07-05 15:32   ` [PATCH 00/11] Add " Lorenzo Bianconi
     [not found]     ` <20180705153216.GE17524-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-07-06 10:36       ` Stanislaw Gruszka
     [not found]         ` <20180706103657.GB2033-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-06 11:37           ` Lorenzo Bianconi
2018-07-07  8:38       ` Hans Ulli Kroll
2018-07-20 10:30         ` Stanislaw Gruszka
     [not found]           ` <20180720103032.GA1791-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-20 10:36             ` Stanislaw Gruszka
2018-07-20 12:18             ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180723093136.GA17285@localhost.localdomain \
    --to=lorenzo.bianconi-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=kubakici-5tc4TXWwyLM@public.gmane.org \
    --cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=nbd-Vt+b4OUoWG0@public.gmane.org \
    --cc=sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).