From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislaw Gruszka Subject: Re: [PATCH 02/17] mt76: rename mt76x2_regs.h Date: Sat, 25 Aug 2018 13:31:51 +0200 Message-ID: <20180825113149.GA13833@redhat.com> References: <1535109321-17126-1-git-send-email-sgruszka@redhat.com> <1535109321-17126-3-git-send-email-sgruszka@redhat.com> <2172355a-0703-e432-96cb-fba2383c3890@nbd.name> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <2172355a-0703-e432-96cb-fba2383c3890-Vt+b4OUoWG0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Felix Fietkau Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lorenzo Bianconi , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Sat, Aug 25, 2018 at 11:00:39AM +0200, Felix Fietkau wrote: > On 2018-08-24 13:15, Stanislaw Gruszka wrote: > > MAC registers are the same for mt76x0 and mt76x2. Rename mt76x2_regs.h > > file to reflect that. > > > > Signed-off-by: Stanislaw Gruszka > > --- > > drivers/net/wireless/mediatek/mt76/mt76x2.h | 2 +- > > drivers/net/wireless/mediatek/mt76/mt76x2_regs.h | 619 ----------------------- > > drivers/net/wireless/mediatek/mt76/mt76xx_regs.h | 619 +++++++++++++++++++++++ > I think mt76xx_regs.h is named too generic. MT7603, MT7628, MT7615 and > all newer chips use a completely different register layout. > I'd prefer to stick with mt76x2_regs for now and use it for x0 as well. I thought about that too, but choose it will be better to have some prefix that will indicate the function/structure/header is shared between the x0 and x2 drivers to not confuse mt76x2 code that is mt76x2 only and one that is shared. I choose mt76xx name, considered mt76 to be generic prefix shared also between old and new chips. But yeah this mt76xx name also "contains" new chips. How about mt76old_ or mt76og_ (old generation) ? Thanks Stanislaw