From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Bianconi Subject: Re: mt76x0 bug report Date: Fri, 7 Sep 2018 10:24:13 +0200 Message-ID: <20180907082413.GC2725@localhost.localdomain> References: <20180906093213.GB16539@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sid Hayn Cc: sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-wireless , Felix Fietkau , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org > Actions like that have caused great problems in the past, as the > kernel won't allow channel control of a monitor interface at all when > there is a managed interface on the same phy (afaik). > > But just for fun and codepath testing here are two test scenarios: > > Test 1: "iwconfig t2u mode monitor" > Sees nothing on any channel, no packets reported > > Test 2(requested test): "iw phy phy11 interface add t2uhmon type monitor" > Sees nothing on any channel, no packets reported. > Despite having a monitor and managed interface on the same phy, > iwconfig is reporting that the channel is changing as requested. So > perhaps my above "afaik" comment is partially outdated. > > For both tests the interface was not used to connect to any ap prior > to or during testing. > Could you please try following patch? Regards, Lorenzo --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c @@ -756,11 +756,10 @@ __mt76x0_phy_set_channel(struct mt76x0_dev *dev, /* Vendor driver don't do it */ /* mt76x0_phy_set_tx_power(dev, channel, rf_bw_band); */ + mt76x0_vco_cal(dev, channel); if (scan) - mt76x0_vco_cal(dev, channel);