From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kimberly Brown Subject: [PATCH v2] staging: mt7621-dma: Add braces around else branches Date: Wed, 24 Oct 2018 00:56:53 -0400 Message-ID: <20181024045653.GA2864@v> References: <20181023211142.GA2661@v> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181023211142.GA2661@v> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: outreachy-kernel@googlegroups.com Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , NeilBrown , linux-mediatek@lists.infradead.org, Kimberly Brown , Matthias Brugger , Christian =?iso-8859-1?Q?L=FCtke-Stetzkamp?= , linux-arm-kernel@lists.infradead.org, John Crispin List-Id: linux-mediatek@lists.infradead.org Add braces around else branches in conditional statements that include branches with multiple statements. This style complies with the Linux kernel coding style and improves consistency and readability. Issues found by checkpatch. Signed-off-by: Kimberly Brown Reviewed-by: Matthias Brugger --- Changes in v2: - Added people and mailing lists from get_maintainer.pl to the CC list - Added Reviewed-by line drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c index df6ebf41bdea..35556f024aa1 100644 --- a/drivers/staging/mt7621-dma/mtk-hsdma.c +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c @@ -418,8 +418,9 @@ static void mtk_hsdma_chan_done(struct mtk_hsdam_engine *hsdma, vchan_cookie_complete(&desc->vdesc); chan_issued = gdma_next_desc(chan); } - } else + } else { dev_dbg(hsdma->ddev.dev, "no desc to complete\n"); + } if (chan_issued) set_bit(chan->id, &hsdma->chan_issued); @@ -456,8 +457,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c) if (gdma_next_desc(chan)) { set_bit(chan->id, &hsdma->chan_issued); tasklet_schedule(&hsdma->task); - } else + } else { dev_dbg(hsdma->ddev.dev, "no desc to issue\n"); + } } spin_unlock_bh(&chan->vchan.lock); } -- 2.17.1