Re: [PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Andrew Lunn
2018-10-30T11:56:38Z

> > > + plat_dat->interface = priv_plat->phy_mode;
> > > + /* clk_csr_i = 250-300MHz & MDC = clk_csr_i/124 */
> > > + plat_dat->clk_csr = 5;
> > > + plat_dat->has_gmac4 = 1;
> > > + plat_dat->has_gmac = 0;
> > > + plat_dat->pmt = 0;
> > > + plat_dat->maxmtu = 1500;
> >
> > ETH_DATA_LEN ?
> how about getting maxmtu from device tree rather than assignment here?

Does it vary between devices? I expect it is a constant, determined by
the DMA hardware design. So no need to make it configurabale.

Andrew