From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Perret Subject: Re: [PATCH 2/2] cpufreq: mediatek: Register an Energy Model Date: Wed, 6 Feb 2019 10:13:18 +0000 Message-ID: <20190206101316.fr7z4ffr4ck4l4aj@queper01-lin> References: <20190205175225.25923-1-mka@chromium.org> <20190205175225.25923-2-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190205175225.25923-2-mka@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Matthias Kaehlcke Cc: "Rafael J . Wysocki" , Viresh Kumar , Matthias Brugger , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Taniya Das , CK Hu , Eddie Huang , Nicolas Boichat , Douglas Anderson List-Id: linux-mediatek@lists.infradead.org Hi Matthias, On Tuesday 05 Feb 2019 at 09:52:25 (-0800), Matthias Kaehlcke wrote: > Try and register an Energy Model from mediatek-cpufreq to allow > interested subsystems like the task scheduler to use the provided > information. > > Signed-off-by: Matthias Kaehlcke > --- > drivers/cpufreq/mediatek-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c > index eb8920d398181..e6168ee582783 100644 > --- a/drivers/cpufreq/mediatek-cpufreq.c > +++ b/drivers/cpufreq/mediatek-cpufreq.c > @@ -460,6 +460,8 @@ static int mtk_cpufreq_init(struct cpufreq_policy *policy) > return ret; > } > > + dev_pm_opp_of_register_em(policy->cpus); I'm not familiar with the mediatek-cpufreq driver so bear with me, but the code sets policy->cpus just below here. Is there any particular reason for not using that in PM_EM ? > cpumask_copy(policy->cpus, &info->cpus); > policy->freq_table = freq_table; > policy->driver_data = info; > -- > 2.20.1.611.gfbb209baf1-goog > Thanks, Quentin