From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH 4/5] mtd: rawnand: mtk: Fix wrongly assigned oob buffer pointer issue Date: Mon, 29 Apr 2019 11:14:25 +0200 Message-ID: <20190429111425.0c91c2f3@xps13> References: <20190429063834.45967-1-xiaolei.li@mediatek.com> <20190429063834.45967-5-xiaolei.li@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190429063834.45967-5-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Xiaolei Li Cc: richard-/L3Ra7n9ekc@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: linux-mediatek@lists.infradead.org SGkgWGlhb2xlaSwKClhpYW9sZWkgTGkgPHhpYW9sZWkubGlAbWVkaWF0ZWsuY29tPiB3cm90ZSBv biBNb24sIDI5IEFwciAyMDE5IDE0OjM4OjMzCiswODAwOgoKPiBPbmUgbWFpbiBnb2FsIG9mIHRo ZSBmdW5jdGlvbiBtdGtfbmZjX3VwZGF0ZV9lY2Nfc3RhdHMgaXMgdG8gY2hlY2sKPiB3aGV0aGVy IHNlY3RvcnMgYXJlIGFsbCBlbXB0eS4gSWYgdGhleSBhcmUgZW1wdHksIHNldCB0aGVzZSBzZWN0 b3JzJ3MKPiBkYXRhIGJ1ZmZlciBhbmQgb29iIGJ1ZmZlciBhcyAweGZmLgo+IAo+IEJ1dCBub3cs IHRoZSBzZWN0b3Igb29iIGJ1ZmZlciBwb2ludGVyIGlzIHdyb25nbHkgYXNzaWduZWQuIFdlIGFs d2F5cwo+IGRvIG1lbXNldCBmcm9tIHNlY3RvciAwLgo+IAo+IFRvIGZpeCB0aGlzIGlzc3VlLCBw YXNzIHN0YXJ0IHNlY290ciBudW1iZXIgdG8gbWFrZSBvb2IgYnVmZmVyIHBvaW50ZXIKCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VjdG9yCgo+IGJlIHByb3Blcmx5IGFzc2lnbmVk LgoKUGxlYXNlIHVzZSB1cHBlciBjYXNlIGZvciBwbGFpbiBFbmdsaXNoIGFjcm9ueW1zOiBOQU5E LCBFQ0MsIE9PQiwgZXRjLgoKPiAKPiBGaXhlczogOTNkYjQ0NmE0MjRjICgibXRkOiBuYW5kOiBt b3ZlIHJhdyBOQU5EIHJlbGF0ZWQgY29kZSB0byB0aGUgcmF3LyBzdWJkaXIiKQoKU2FtZSBjb21t ZW50IGFzIGJlZm9yZSwgd3JvbmcgY29tbWl0IHBvaW50ZWQgaW4gdGhlIEZpeGVzIHRhZy4KCj4g U2lnbmVkLW9mZi1ieTogWGlhb2xlaSBMaSA8eGlhb2xlaS5saUBtZWRpYXRlay5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L210a19uYW5kLmMgfCAyMSArKysrKysrKysrLS0tLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tdGtfbmFuZC5jIGIvZHJp dmVycy9tdGQvbmFuZC9yYXcvbXRrX25hbmQuYwo+IGluZGV4IDdhNWU4YzljZjYxYi4uY2Y1ZTUw ZTcwNGFlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L210a19uYW5kLmMKPiAr KysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tdGtfbmFuZC5jCj4gQEAgLTg3MywxOSArODczLDIx IEBAIHN0YXRpYyBpbnQgbXRrX25mY193cml0ZV9vb2Jfc3RkKHN0cnVjdCBuYW5kX2NoaXAgKmNo aXAsIGludCBwYWdlKQo+ICAJcmV0dXJuIG10a19uZmNfd3JpdGVfcGFnZV9yYXcoY2hpcCwgTlVM TCwgMSwgcGFnZSk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgbXRrX25mY191cGRhdGVfZWNjX3N0 YXRzKHN0cnVjdCBtdGRfaW5mbyAqbXRkLCB1OCAqYnVmLCB1MzIgc2VjdG9ycykKPiArc3RhdGlj IGludCBtdGtfbmZjX3VwZGF0ZV9lY2Nfc3RhdHMoc3RydWN0IG10ZF9pbmZvICptdGQsIHU4ICpi dWYsIHUzMiBzdGFydCwKPiArCQkJCSAgICB1MzIgc2VjdG9ycykKPiAgewo+ICAJc3RydWN0IG5h bmRfY2hpcCAqY2hpcCA9IG10ZF90b19uYW5kKG10ZCk7Cj4gIAlzdHJ1Y3QgbXRrX25mYyAqbmZj ID0gbmFuZF9nZXRfY29udHJvbGxlcl9kYXRhKGNoaXApOwo+ICAJc3RydWN0IG10a19uZmNfbmFu ZF9jaGlwICptdGtfbmFuZCA9IHRvX210a19uYW5kKGNoaXApOwo+ICAJc3RydWN0IG10a19lY2Nf c3RhdHMgc3RhdHM7Cj4gKwl1MzIgcmVnX3NpemUgPSBtdGtfbmFuZC0+ZmRtLnJlZ19zaXplOwo+ ICAJaW50IHJjLCBpOwo+ICAKPiAgCXJjID0gbmZpX3JlYWRsKG5mYywgTkZJX1NUQSkgJiBTVEFf RU1QX1BBR0U7Cj4gIAlpZiAocmMpIHsKPiAgCQltZW1zZXQoYnVmLCAweGZmLCBzZWN0b3JzICog Y2hpcC0+ZWNjLnNpemUpOwo+ICAJCWZvciAoaSA9IDA7IGkgPCBzZWN0b3JzOyBpKyspCj4gLQkJ CW1lbXNldChvb2JfcHRyKGNoaXAsIGkpLCAweGZmLCBtdGtfbmFuZC0+ZmRtLnJlZ19zaXplKTsK PiArCQkJbWVtc2V0KG9vYl9wdHIoY2hpcCwgc3RhcnQgKyBpKSwgMHhmZiwgcmVnX3NpemUpOwo+ ICAJCXJldHVybiAwOwo+ICAJfQo+ICAKPiBAQCAtOTA1LDcgKzkwNyw3IEBAIHN0YXRpYyBpbnQg bXRrX25mY19yZWFkX3N1YnBhZ2Uoc3RydWN0IG10ZF9pbmZvICptdGQsIHN0cnVjdCBuYW5kX2No aXAgKmNoaXAsCj4gIAl1MzIgc3BhcmUgPSBtdGtfbmFuZC0+c3BhcmVfcGVyX3NlY3RvcjsKPiAg CXUzMiBjb2x1bW4sIHNlY3RvcnMsIHN0YXJ0LCBlbmQsIHJlZzsKPiAgCWRtYV9hZGRyX3QgYWRk cjsKPiAtCWludCBiaXRmbGlwczsKPiArCWludCBiaXRmbGlwcyA9IDA7Cj4gIAlzaXplX3QgbGVu Owo+ICAJdTggKmJ1ZjsKPiAgCWludCByYzsKPiBAQCAtOTcyLDE0ICs5NzQsMTEgQEAgc3RhdGlj IGludCBtdGtfbmZjX3JlYWRfc3VicGFnZShzdHJ1Y3QgbXRkX2luZm8gKm10ZCwgc3RydWN0IG5h bmRfY2hpcCAqY2hpcCwKPiAgCWlmIChyYyA8IDApIHsKPiAgCQlkZXZfZXJyKG5mYy0+ZGV2LCAi c3VicGFnZSBkb25lIHRpbWVvdXRcbiIpOwo+ICAJCWJpdGZsaXBzID0gLUVJTzsKPiAtCX0gZWxz ZSB7Cj4gLQkJYml0ZmxpcHMgPSAwOwo+IC0JCWlmICghcmF3KSB7Cj4gLQkJCXJjID0gbXRrX2Vj Y193YWl0X2RvbmUobmZjLT5lY2MsIEVDQ19ERUNPREUpOwo+IC0JCQliaXRmbGlwcyA9IHJjIDwg MCA/IC1FVElNRURPVVQgOgo+IC0JCQkJbXRrX25mY191cGRhdGVfZWNjX3N0YXRzKG10ZCwgYnVm LCBzZWN0b3JzKTsKPiAtCQkJbXRrX25mY19yZWFkX2ZkbShjaGlwLCBzdGFydCwgc2VjdG9ycyk7 Cj4gLQkJfQo+ICsJfSBlbHNlIGlmICghcmF3KSB7Cj4gKwkJcmMgPSBtdGtfZWNjX3dhaXRfZG9u ZShuZmMtPmVjYywgRUNDX0RFQ09ERSk7Cj4gKwkJYml0ZmxpcHMgPSByYyA8IDAgPyAtRVRJTUVE T1VUIDoKPiArCQkJbXRrX25mY191cGRhdGVfZWNjX3N0YXRzKG10ZCwgYnVmLCBzdGFydCwgc2Vj dG9ycyk7Cj4gKwkJbXRrX25mY19yZWFkX2ZkbShjaGlwLCBzdGFydCwgc2VjdG9ycyk7Cj4gIAl9 Cj4gIAo+ICAJZG1hX3VubWFwX3NpbmdsZShuZmMtPmRldiwgYWRkciwgbGVuLCBETUFfRlJPTV9E RVZJQ0UpOwoKV2l0aCB0aGlzIGFkZHJlc3NlZDoKClJldmlld2VkLWJ5OiBNaXF1ZWwgUmF5bmFs IDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPgoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFp bGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo=