From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [bug report] mt76: add mac80211 driver for MT7615 PCIe-based chipsets
Date: Fri, 3 May 2019 16:06:42 +0300 [thread overview]
Message-ID: <20190503130642.GH29695@mwanda> (raw)
Hello Ryder Lee,
This is a semi-automatic email about new static checker warnings.
The patch 04b8e65922f6: "mt76: add mac80211 driver for MT7615
PCIe-based chipsets" from Apr 1, 2019, leads to the following Smatch
complaint:
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:1012 mt7615_mcu_set_wtbl_key()
error: we previously assumed 'key' could be null (see line 1008)
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
1007 cipher = mt7615_get_key_info(key, wtbl_sec_key.key_material);
1008 if (cipher == MT_CIPHER_NONE && key)
^^^
This check doesn't make much sense. Do you want to just remove it?
1009 return -EOPNOTSUPP;
1010
1011 wtbl_sec_key.cipher_id = cipher;
1012 wtbl_sec_key.key_id = key->keyidx;
^^^^^^^^^^^
1013 wtbl_sec_key.key_len = key->keylen;
1014 } else {
regards,
dan carpenter
next reply other threads:[~2019-05-03 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 13:06 Dan Carpenter [this message]
2019-05-04 0:01 ` [bug report] mt76: add mac80211 driver for MT7615 PCIe-based chipsets Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503130642.GH29695@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).