From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [bug report] mt76: add mac80211 driver for MT7615 PCIe-based chipsets Date: Fri, 3 May 2019 16:06:42 +0300 Message-ID: <20190503130642.GH29695@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org Hello Ryder Lee, This is a semi-automatic email about new static checker warnings. The patch 04b8e65922f6: "mt76: add mac80211 driver for MT7615 PCIe-based chipsets" from Apr 1, 2019, leads to the following Smatch complaint: drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:1012 mt7615_mcu_set_wtbl_key() error: we previously assumed 'key' could be null (see line 1008) drivers/net/wireless/mediatek/mt76/mt7615/mcu.c 1007 cipher = mt7615_get_key_info(key, wtbl_sec_key.key_material); 1008 if (cipher == MT_CIPHER_NONE && key) ^^^ This check doesn't make much sense. Do you want to just remove it? 1009 return -EOPNOTSUPP; 1010 1011 wtbl_sec_key.cipher_id = cipher; 1012 wtbl_sec_key.key_id = key->keyidx; ^^^^^^^^^^^ 1013 wtbl_sec_key.key_len = key->keylen; 1014 } else { regards, dan carpenter