Re: [RFC PATCH v3 1/1] mtd: rawnand: mtk: Re-license MTK NAND driver as Dual MIT/GPL

Rafał Miłecki
2019-05-05T15:06:36Z

On 2019-05-05 11:12, xiaolei li wrote:
> Up to now,
> Xiaolei Li <xiaolei.li@mediatek.com> (the author and major
> contributor),
> Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> (the author and
> major contributor),
> Ryder Lee <ryder.lee@mediatek.com> (developer),
> Rafał Miłecki <rafal@milecki.pl> (developer)
> sent ACK for this RFC patch.
>
> May I ask if it is enough to accept this change? Or should I wait for
> other developer's response?

I can't imagine re-licensing someone's work without a permission.

The best you can do is ignoring contributors that submitted changes that
aren't really copyrightable (something like fixing a comment typo, some
auto-generated diff-s).

I used following command to check mtk_nand.c file history:
# git log --follow drivers/mtd/nand/raw/mtk_nand.c | grep
"Signed-off-by" | sort | uniq -c | sort -r -n
19 Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
18 Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
15 Signed-off-by: Boris Brezillon
<boris.brezillon@free-electrons.com>
6 Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
3 Signed-off-by: RogerCC Lin <rogercc.lin@mediatek.com>
2 Signed-off-by: Miquel Raynal
<miquel.raynal@free-electrons.com>
1 Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
1 Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
1 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
1 Signed-off-by: Peter Pan <peterpandong@micron.com>
1 Signed-off-by: Masahiro Yamada
<yamada.masahiro@socionext.com>
1 Signed-off-by: Jorge Ramirez-Ortiz
<jorge.ramirez-ortiz@linaro.org>

Ideally you should still get acks from:

1) Miquel
Contributor of 21 changes

2) Boris
Contributor of 33 changes

3) RogerCC
Contributor of 3 changes:
98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.")
b45ee5501ede ("mtd: nand: mtk: Support different MTK NAND flash
controller IP")
559e58e7ed2d ("mtd: nand: fix chances to create incomplete ECC data when
writing")

4) Wei
Contributor of 1 change:
07f76443ef81 ("mtd: nand: mediatek: remove redundant dev_err call in
mtk_nfc_probe()")

5) Peter
Contributor of 1 change:
d4092d76a4a4 ("mtd: nand: Rename nand.h into rawnand.h")

6) Masahiro
Contributor of 1 change:
f0dbe4aa35e7 ("mtd: nand: mediatek: return error code of
nand_scan_ident/tail() on error")

I guess we could accept your patch without acks from Wei, Peter and
Masahiro.

You definitely need an approval from Miquel, Boris and RogerCC.

It doesn't seem you took this re-licensing task too seriously.

Please pay more attention to this licensing problem, you can start with
doing
a similar research for mtk_ecc.c and mtk_ecc.h.