From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH] dmaengine: mediatek-cqdma: sleeping in atomic context Date: Tue, 21 May 2019 10:28:51 +0530 Message-ID: <20190521045851.GR15118@vkoul-mobl> References: <20190509100923.GA7024@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190509100923.GA7024@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Dan Carpenter Cc: Sean Wang , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Shun-Chih Yu , Matthias Brugger , Dan Williams List-Id: linux-mediatek@lists.infradead.org On 09-05-19, 13:09, Dan Carpenter wrote: > The mtk_cqdma_poll_engine_done() function takes a true/false parameter > where true means it's called from atomic context. There are a couple > places where it was set to false but it's actually in atomic context > so it should be true. > > All the callers for mtk_cqdma_hard_reset() are holding a spin_lock and > in mtk_cqdma_free_chan_resources() we take a spin_lock before calling > the mtk_cqdma_poll_engine_done() function. Applied, thanks > > Fixes: b1f01e48df5a ("dmaengine: mediatek: Add MediaTek Command-Queue DMA controller for MT6765 SoC") > Signed-off-by: Dan Carpenter > --- > The "atomic" parameter is always true so the temptation was to just > remove it entirely. a patch is welcome :) -- ~Vinod