From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace Date: Wed, 21 Aug 2019 05:39:33 -0700 Message-ID: <20190821123933.GC4059@kroah.com> References: <20190813121733.52480-1-maennich@google.com> <20190821114955.12788-1-maennich@google.com> <20190821114955.12788-12-maennich@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190821114955.12788-12-maennich-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Matthias Maennich Cc: Tomer Maimon , lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kevin Hilman , Michal Simek , Ludovic Desroches , mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org, NXP Linux Team , Tomas Winkler , Guenter Roeck , Jean Delvare , Sascha Hauer , tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, michal.lkml-yyZNWGI4GtDR7s880joybQ@public.gmane.org, Scott Branden , Andrew Jeffery , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pengutronix Kernel Team , Alexandre Belloni , linux-aspeed-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org, Thierry Reding List-Id: linux-mediatek@lists.infradead.org On Wed, Aug 21, 2019 at 12:49:26PM +0100, Matthias Maennich wrote: > Modules using these symbols are required to explicitly import the > namespace. This patch was generated with the following steps and serves > as a reference to use the symbol namespace feature: > > 1) Use EXPORT_SYMBOL_NS* macros instead of EXPORT_SYMBOL* for symbols > in watchdog_core.c > 2) make (see warnings during modpost about missing imports) > 3) make nsdeps > > I used 'allmodconfig' for the above steps to ensure all occurrences are > patched. > > Defining DEFAULT_SYMBOL_NAMESPACE in the Makefile is not trivial in this > case as not only watchdog_core is defined in drivers/watchdog/Makefile. > Hence this patch uses the variant of using the EXPORT_SYMBOL_NS* macros > to export into a different namespace. > > An alternative to this patch would be a single definition line before > any use of EXPORT_SYMBOL*: > #define DEFAULT_SYMBOL_NAMESPACE WATCHDOG_CORE > > Signed-off-by: Matthias Maennich As we talked in chat, the cc: list for this patch was crazy :) If you end up resending this (as odds are the mailing lists will trash it for too many recipients), feel free to add: Reviewed-by: Greg Kroah-Hartman Great work, greg k-h