From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5 Date: Sat, 24 Aug 2019 23:29:35 +0100 Message-ID: <20190824222935.GG13294@shell.armlinux.org.uk> References: <20190821144547.15113-1-opensource@vdorst.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190821144547.15113-1-opensource@vdorst.com> Sender: netdev-owner@vger.kernel.org To: =?iso-8859-1?Q?Ren=E9?= van Dorst Cc: Sean Wang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" , Matthias Brugger , Frank Wunderlich , netdev@vger.kernel.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, John Crispin , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On Wed, Aug 21, 2019 at 04:45:44PM +0200, René van Dorst wrote: > 1. net: dsa: mt7530: Convert to PHYLINK API > This patch converts mt7530 to PHYLINK API. > 2. dt-bindings: net: dsa: mt7530: Add support for port 5 > 3. net: dsa: mt7530: Add support for port 5 > These 2 patches adding support for port 5 of the switch. > > v1->v2: > * Mostly phylink improvements after review. > rfc -> v1: > * Mostly phylink improvements after review. > * Drop phy isolation patches. Adds no value for now. > René van Dorst (3): > net: dsa: mt7530: Convert to PHYLINK API > dt-bindings: net: dsa: mt7530: Add support for port 5 > net: dsa: mt7530: Add support for port 5 > > .../devicetree/bindings/net/dsa/mt7530.txt | 218 ++++++++++ > drivers/net/dsa/mt7530.c | 371 +++++++++++++++--- > drivers/net/dsa/mt7530.h | 61 ++- > 3 files changed, 577 insertions(+), 73 deletions(-) Having looked through this set of patches, I don't see anything from the phylink point of view that concerns me. So, for the series from the phylink perspective: Acked-by: Russell King Thanks. I did notice a dev_info() in patch 3 that you may like to consider whether they should be printed at info level or debug level. You may keep my ack on the patch when fixing that. I haven't considered whether the patch passes davem's style requirements for networking code; what I spotted did look like the declarations were upside-down christmas tree. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up