From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy Date: Thu, 29 Aug 2019 14:23:41 -0500 Message-ID: <20190829192341.GA26293@bogus> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Chunfeng Yun Cc: Kishon Vijay Abraham I , Mark Rutland , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org On Fri, Aug 23, 2019 at 03:00:08PM +0800, Chunfeng Yun wrote: > Add two optional properties, one for J-K test, another for disconnect > threshold, both of them can be used to debug disconnection issues. Testing and debug properties aren't really things that belong in DT. > > Signed-off-by: Chunfeng Yun > --- > Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > index a5f7a4f0dbc1..d5b327f85fa2 100644 > --- a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > +++ b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt > @@ -52,6 +52,8 @@ Optional properties (PHY_TYPE_USB2 port (child) node): > - mediatek,eye-vrt : u32, the selection of VRT reference voltage > - mediatek,eye-term : u32, the selection of HS_TX TERM reference voltage > - mediatek,bc12 : bool, enable BC12 of u2phy if support it > +- mediatek,discth : u32, the voltage of disconnect threshold > +- mediatek,intr : u32, the value of internal R (resistance) These need units as defined in property-units.txt. > > Example: > > -- > 2.23.0 >