Re: [PATCH -next 34/36] spi: zynqmp: use devm_platform_ioremap_resource() to simplify code

Michal Simek
2019-09-05T05:19:47Z

On 04. 09. 19 15:59, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/spi/spi-zynqmp-gqspi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
> index 5e9ea8a..60c4de4 100644
> --- a/drivers/spi/spi-zynqmp-gqspi.c
> +++ b/drivers/spi/spi-zynqmp-gqspi.c
> @@ -1016,7 +1016,6 @@ static int zynqmp_qspi_probe(struct platform_device *pdev)
> int ret = 0;
> struct spi_master *master;
> struct zynqmp_qspi *xqspi;
> - struct resource *res;
> struct device *dev = &pdev->dev;
>
> eemi_ops = zynqmp_pm_get_eemi_ops();
> @@ -1031,8 +1030,7 @@ static int zynqmp_qspi_probe(struct platform_device *pdev)
> master->dev.of_node = pdev->dev.of_node;
> platform_set_drvdata(pdev, master);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - xqspi->regs = devm_ioremap_resource(&pdev->dev, res);
> + xqspi->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(xqspi->regs)) {
> ret = PTR_ERR(xqspi->regs);
> goto remove_master;
>

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal