Re: [PATCH -next 15/36] spi: meson-spicc: use devm_platform_ioremap_resource() to simplify code

Neil Armstrong
2019-09-04T14:13:41Z

On 04/09/2019 15:58, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/spi/spi-meson-spicc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
> index 7fe4488..f3f1044 100644
> --- a/drivers/spi/spi-meson-spicc.c
> +++ b/drivers/spi/spi-meson-spicc.c
> @@ -503,7 +503,6 @@ static int meson_spicc_probe(struct platform_device *pdev)
> {
> struct spi_master *master;
> struct meson_spicc_device *spicc;
> - struct resource *res;
> int ret, irq, rate;
>
> master = spi_alloc_master(&pdev->dev, sizeof(*spicc));
> @@ -517,8 +516,7 @@ static int meson_spicc_probe(struct platform_device *pdev)
> spicc->pdev = pdev;
> platform_set_drvdata(pdev, spicc);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - spicc->base = devm_ioremap_resource(&pdev->dev, res);
> + spicc->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(spicc->base)) {
> dev_err(&pdev->dev, "io resource mapping failed\n");
> ret = PTR_ERR(spicc->base);
>

Acked-by: Neil Armstrong <narmstrong@baylibre.com>