Re: [PATCH -next 35/36] spi: zynq-qspi: use devm_platform_ioremap_resource() to simplify code

Michal Simek
2019-09-05T05:19:56Z

On 04. 09. 19 15:59, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/spi/spi-zynq-qspi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c
> index 4a5326c..5cf6993 100644
> --- a/drivers/spi/spi-zynq-qspi.c
> +++ b/drivers/spi/spi-zynq-qspi.c
> @@ -620,7 +620,6 @@ static int zynq_qspi_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> struct zynq_qspi *xqspi;
> - struct resource *res;
> u32 num_cs;
>
> ctlr = spi_alloc_master(&pdev->dev, sizeof(*xqspi));
> @@ -630,8 +629,7 @@ static int zynq_qspi_probe(struct platform_device *pdev)
> xqspi = spi_controller_get_devdata(ctlr);
> xqspi->dev = dev;
> platform_set_drvdata(pdev, xqspi);
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - xqspi->regs = devm_ioremap_resource(&pdev->dev, res);
> + xqspi->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(xqspi->regs)) {
> ret = PTR_ERR(xqspi->regs);
> goto remove_master;
>

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal