From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: mt6360: add pmic mt6360 driver Date: Tue, 24 Sep 2019 21:38:48 +0100 Message-ID: <20190924203848.GC4469@dell> References: <1568801744-21380-1-git-send-email-gene.chen.richtek@gmail.com> <20190918105121.GB5016@dell> <20190919071828.GC5016@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Gene Chen Cc: matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com List-Id: linux-mediatek@lists.infradead.org On Tue, 24 Sep 2019, Gene Chen wrote: > 2019-09-19 15:18 GMT+08:00, Lee Jones : > > On Thu, 19 Sep 2019, Gene Chen wrote: > > > >> Lee Jones 於 2019年9月18日 週三 下午6:51寫道： > >> > > >> > On Wed, 18 Sep 2019, Gene Chen wrote: > >> > > >> > > From: Gene Chen > >> > > > >> > > Add mfd driver for mt6360 pmic chip include > >> > > Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck > >> > > > >> > > Signed-off-by: Gene Chen >> > > --- > >> > > >> > This looks different from the one you sent before, but I don't see a > >> > version bump or any changelog in this space. Please re-submit with > >> > the differences noted. > >> > > >> > >> the change is > >> 1. add missing include file > >> 2. modify commit message > >> > >> this patch is regarded as version 1 > > > > It's different to the first one you sent to the list, so it needs a > > version bump and a change log. There also appears to still be issues > > with it, if the auto-builders are to be believed. > > > > Do ensure you thoroughly test your patches before sending upstream. > > > > Please fix the issues and resubmit your v3 with a nice changelog. > > > > thank you for suggestion > may i ask how to disable kbuild test reboot for s390/x86_64/ia64? > we want support only cross compiler = aarch64-linux-gnu- > and we have test build pass with our patch You can't and we wouldn't want to. If this driver should only be built/tested for AArch64, you need to ensure the Kconfig represents that. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog