From: Thierry Reding <thierry.reding@gmail.com>
To: Sam Shih <sam.shih@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>,
John Crispin <john@phrozen.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v10 07/12] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms"
Date: Thu, 26 Sep 2019 00:50:05 +0200 [thread overview]
Message-ID: <20190925225005.GB8115@mithrandir> (raw)
In-Reply-To: <1569421957-20765-8-git-send-email-sam.shih@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
On Wed, Sep 25, 2019 at 10:32:32PM +0800, Sam Shih wrote:
> From: Ryder Lee <ryder.lee@mediatek.com>
>
> This adds a property "num-pwms" in example so that we could
> specify the number of PWM channels via device tree.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Changes since v10:
> 1. Follow reviewers's comments:
> - derive the number of PWMs from the specific compatible string
[...]
> + - num-pwms: the number of PWM channels.
[...]
Why is num-pwms still there if you derive it from the compatible string?
I guess I must not have made myself clear. Please drop this.
Also, as I mentioned earlier, I've already applied the patches from v9
that were suitable. Please take a look.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-25 22:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 14:32 [PATCH v10 0/12] Add mt7629 and fix mt7628 pwm Sam Shih
2019-09-25 14:32 ` [PATCH v10 01/12] pwm: mediatek: add a property "num-pwms" Sam Shih
2019-09-25 14:32 ` [PATCH v10 02/12] pwm: mediatek: droping the check for of_device_get_match_data Sam Shih
2019-09-25 14:32 ` [PATCH v10 03/12] pwm: mediatek: remove a property "has-clks" Sam Shih
2019-09-25 14:32 ` [PATCH v10 04/12] pwm: mediatek: allocate the clks array dynamically Sam Shih
2019-09-25 14:32 ` [PATCH v10 05/12] pwm: mediatek: use pwm_mediatek as common prefix Sam Shih
2019-09-25 14:32 ` [PATCH v10 06/12] pwm: mediatek: update license and switch to SPDX tag Sam Shih
2019-09-25 14:32 ` [PATCH v10 07/12] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms" Sam Shih
2019-09-25 22:50 ` Thierry Reding [this message]
2019-09-25 14:32 ` [PATCH v10 08/12] pwm: mediatek: Add MT7629 compatible string Sam Shih
[not found] ` <1569421957-20765-9-git-send-email-sam.shih-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-09-27 11:28 ` Thierry Reding
2019-09-30 8:51 ` Sam Shih
2019-09-30 9:36 ` Thierry Reding
2019-09-30 9:51 ` Sam Shih
2019-09-25 14:32 ` [PATCH v10 09/12] arm64: dts: mt7622: add a property "num-pwms" for PWM Sam Shih
2019-09-25 14:32 ` [PATCH v10 10/12] arm: dts: mt7623: " Sam Shih
2019-09-25 14:32 ` [PATCH v10 11/12] dt-bindings: pwm: update bindings for MT7629 SoC Sam Shih
2019-09-25 14:32 ` [PATCH v10 12/12] arm: dts: mediatek: add mt7629 pwm support Sam Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925225005.GB8115@mithrandir \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sam.shih@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).