From: Thierry Reding <thierry.reding@gmail.com>
To: Sam Shih <sam.shih@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>,
John Crispin <john@phrozen.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v10 08/12] pwm: mediatek: Add MT7629 compatible string
Date: Mon, 30 Sep 2019 11:36:29 +0200 [thread overview]
Message-ID: <20190930093629.GH1518582@ulmo> (raw)
In-Reply-To: <1569833468.32131.4.camel@mtksdccf07>
[-- Attachment #1: Type: text/plain, Size: 2950 bytes --]
On Mon, Sep 30, 2019 at 04:51:08PM +0800, Sam Shih wrote:
> Hi,
>
> On Fri, 2019-09-27 at 13:28 +0200, Thierry Reding wrote:
> > On Wed, Sep 25, 2019 at 10:32:33PM +0800, Sam Shih wrote:
> > > This adds pwm support for MT7629, and separate mt7629 compatible string
> > > from mt7622
> > >
> > > Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> > > ---
> > > drivers/pwm/pwm-mediatek.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> >
> > I picked this patch up and made some minor adjustments to make it build
> > without the num_pwms patches. With that I don't think there's anything
> > left from this series that you need.
>
> Yes, I think the driver should work once dtsi updated.
> ("[v10,12/12] arm: dts: mediatek: add mt7629 pwm support")
>
> But, due to we use comaptible string separately for every SoC now,
> The comaptible string in dt-bindings should be "mediatek,mt7629-pwm".
> I think we should use "[v10,11/12] dt-bindings: pwm: update bindings
> for MT7629" to replace commit 1c00ad6ebf36aa3b0fa598a48b8ae59782be4121,
> Or maybe we need a little modification like this ?
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt ...
> - - "mediatek,mt7629-pwm", "mediatek,mt7622-pwm": found on mt7629 SoC.
> + - "mediatek,mt7629-pwm": found on mt7629 SoC.
Good catch, I must've taken this from the wrong version of the patch.
How about the attached patch?
Thanks,
Thierry
--- >8 ---
From 641b0ee176b139f9edd137ba636ca0cb9c63289a Mon Sep 17 00:00:00 2001
From: Thierry Reding <thierry.reding@gmail.com>
Date: Mon, 30 Sep 2019 11:33:31 +0200
Subject: [PATCH] dt-bindings: pwm: mediatek: Remove gratuitous compatible
string for MT7629
The MT7629 is, in fact, not compatible with the MT7622 because the
former has a single PWM channel while the former has 6. Remove the
gratuitous compatible string for MT7629.
Reported-by: Sam Shih <sam.shih@mediatek.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---
Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
index c8501530173c..053e9b5880f1 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
@@ -6,7 +6,7 @@ Required properties:
- "mediatek,mt7622-pwm": found on mt7622 SoC.
- "mediatek,mt7623-pwm": found on mt7623 SoC.
- "mediatek,mt7628-pwm": found on mt7628 SoC.
- - "mediatek,mt7629-pwm", "mediatek,mt7622-pwm": found on mt7629 SoC.
+ - "mediatek,mt7629-pwm": found on mt7629 SoC.
- "mediatek,mt8516-pwm": found on mt8516 SoC.
- reg: physical base address and length of the controller's registers.
- #pwm-cells: must be 2. See pwm.txt in this directory for a description of
--
2.23.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-30 9:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 14:32 [PATCH v10 0/12] Add mt7629 and fix mt7628 pwm Sam Shih
2019-09-25 14:32 ` [PATCH v10 01/12] pwm: mediatek: add a property "num-pwms" Sam Shih
2019-09-25 14:32 ` [PATCH v10 02/12] pwm: mediatek: droping the check for of_device_get_match_data Sam Shih
2019-09-25 14:32 ` [PATCH v10 03/12] pwm: mediatek: remove a property "has-clks" Sam Shih
2019-09-25 14:32 ` [PATCH v10 04/12] pwm: mediatek: allocate the clks array dynamically Sam Shih
2019-09-25 14:32 ` [PATCH v10 05/12] pwm: mediatek: use pwm_mediatek as common prefix Sam Shih
2019-09-25 14:32 ` [PATCH v10 06/12] pwm: mediatek: update license and switch to SPDX tag Sam Shih
2019-09-25 14:32 ` [PATCH v10 07/12] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms" Sam Shih
2019-09-25 22:50 ` Thierry Reding
2019-09-25 14:32 ` [PATCH v10 08/12] pwm: mediatek: Add MT7629 compatible string Sam Shih
[not found] ` <1569421957-20765-9-git-send-email-sam.shih-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-09-27 11:28 ` Thierry Reding
2019-09-30 8:51 ` Sam Shih
2019-09-30 9:36 ` Thierry Reding [this message]
2019-09-30 9:51 ` Sam Shih
2019-09-25 14:32 ` [PATCH v10 09/12] arm64: dts: mt7622: add a property "num-pwms" for PWM Sam Shih
2019-09-25 14:32 ` [PATCH v10 10/12] arm: dts: mt7623: " Sam Shih
2019-09-25 14:32 ` [PATCH v10 11/12] dt-bindings: pwm: update bindings for MT7629 SoC Sam Shih
2019-09-25 14:32 ` [PATCH v10 12/12] arm: dts: mediatek: add mt7629 pwm support Sam Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930093629.GH1518582@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sam.shih@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).