From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v10 08/12] pwm: mediatek: Add MT7629 compatible string Date: Mon, 30 Sep 2019 11:36:29 +0200 Message-ID: <20190930093629.GH1518582@ulmo> References: <1569421957-20765-1-git-send-email-sam.shih@mediatek.com> <1569421957-20765-9-git-send-email-sam.shih@mediatek.com> <20190927112831.GA1171568@ulmo> <1569833468.32131.4.camel@mtksdccf07> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9jHkwA2TBA/ec6v+" Return-path: Content-Disposition: inline In-Reply-To: <1569833468.32131.4.camel@mtksdccf07> Sender: linux-kernel-owner@vger.kernel.org To: Sam Shih Cc: Rob Herring , Mark Rutland , Matthias Brugger , Ryder Lee , John Crispin , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org --9jHkwA2TBA/ec6v+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 30, 2019 at 04:51:08PM +0800, Sam Shih wrote: > Hi, >=20 > On Fri, 2019-09-27 at 13:28 +0200, Thierry Reding wrote: > > On Wed, Sep 25, 2019 at 10:32:33PM +0800, Sam Shih wrote: > > > This adds pwm support for MT7629, and separate mt7629 compatible stri= ng > > > from mt7622 > > >=20 > > > Signed-off-by: Sam Shih > > > --- > > > drivers/pwm/pwm-mediatek.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > >=20 > > I picked this patch up and made some minor adjustments to make it build > > without the num_pwms patches. With that I don't think there's anything > > left from this series that you need. >=20 > Yes, I think the driver should work once dtsi updated. > ("[v10,12/12] arm: dts: mediatek: add mt7629 pwm support") >=20 > But, due to we use comaptible string separately for every SoC now, > The comaptible string in dt-bindings should be "mediatek,mt7629-pwm". > I think we should use "[v10,11/12] dt-bindings: pwm: update bindings=20 > for MT7629" to replace commit 1c00ad6ebf36aa3b0fa598a48b8ae59782be4121, > Or maybe we need a little modification like this ? > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt ... > - - "mediatek,mt7629-pwm", "mediatek,mt7622-pwm": found on mt7629 SoC. > + - "mediatek,mt7629-pwm": found on mt7629 SoC. Good catch, I must've taken this from the wrong version of the patch. How about the attached patch? Thanks, Thierry --- >8 --- =46rom 641b0ee176b139f9edd137ba636ca0cb9c63289a Mon Sep 17 00:00:00 2001 =46rom: Thierry Reding Date: Mon, 30 Sep 2019 11:33:31 +0200 Subject: [PATCH] dt-bindings: pwm: mediatek: Remove gratuitous compatible string for MT7629 The MT7629 is, in fact, not compatible with the MT7622 because the former has a single PWM channel while the former has 6. Remove the gratuitous compatible string for MT7629. Reported-by: Sam Shih Signed-off-by: Thierry Reding --- Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Docum= entation/devicetree/bindings/pwm/pwm-mediatek.txt index c8501530173c..053e9b5880f1 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt @@ -6,7 +6,7 @@ Required properties: - "mediatek,mt7622-pwm": found on mt7622 SoC. - "mediatek,mt7623-pwm": found on mt7623 SoC. - "mediatek,mt7628-pwm": found on mt7628 SoC. - - "mediatek,mt7629-pwm", "mediatek,mt7622-pwm": found on mt7629 SoC. + - "mediatek,mt7629-pwm": found on mt7629 SoC. - "mediatek,mt8516-pwm": found on mt8516 SoC. - reg: physical base address and length of the controller's registers. - #pwm-cells: must be 2. See pwm.txt in this directory for a description = of --=20 2.23.0 --9jHkwA2TBA/ec6v+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl2RzJoACgkQ3SOs138+ s6Fu6BAAuRcu3USNLrzJfAKIB1Wgkn0/BdRRi5vnFfGVSQ/CTCPsHwPve+B4ggdD KO/QA24iY4G/Jejm6tj2wFt5vw4j12jXaA1oo9Nk2CsfY7JsxhWYLwyB9dn41bxE Psooim1/HcwlwzWk2KX3h8kEiBV/xdeppMXog5ab1gXxMMs1j4cxSqEl8Flmal9b CwwxZMK21DNl4fZC6R+BUJ/94p7cJ0sOE198wr0Dm87u+faAlPw/VcVeslCOgVLQ 7G9/NxusfiTjUPSSWrfvJ0vVqXm+bCEAeeONJjr2XqonMr8W2Ch+muv8xB+bsnUY 8Y2U2nO8TrE9WGRq2WLG8+VOMykfJ2pFSb90rtt7IiGIas6EeEzLEaBrO4KAQeC7 OzjEA8Q/JywpyKL9IwNCwvDrvbeT4NC5AM7IJmzZ/bZeQwTLi0Zvoju/SqkYb100 DHZYjV2PcYS6jXQAdo/hMCsQj3MqSzPbNn7j9apiFE/n/Y4SQJiank7jlHleRUmx JE58Se7Ge8biW5p2OQzqFk9/4j/4V0aEwdezZFjoS58hIWla+4oGLAU4M4meDnTU xPHQZZM2tEg1mrkKhmkd6s+nGSD47bFZP49/+wjRdn1llDxJG9beNUpFiII5HKR9 3G1y3FsgjCMRWuELFVBXF8hqPC4P/MDk+bUQaSCRzaPwAT7NnwQ= =DGcd -----END PGP SIGNATURE----- --9jHkwA2TBA/ec6v+--