From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457D8C5DF62 for ; Wed, 6 Nov 2019 08:51:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C33A2187F for ; Wed, 6 Nov 2019 08:51:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SVGYL2iB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dW9xxWMW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C33A2187F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n9Wv+jtBH++d2jIxOitfKNAn96/zWpMQVbCp2qhOixM=; b=SVGYL2iBCHnyus mJerBdQwJqBtWJ2Dru9Qq+hTe6aj25PyD7bOH8bttsIA6MFdA2L5QU+IQUWS7/3Ek0D3pHgOovxoD gH6XHVQG4lRLmOmHVzuDSsnfOzDiMg7P2y8Y6wVp4M5Tit2D8+MvwcJ7IpRcSL6OBRbQJvU64aW/N 4Duo+2zaEXFU5B03O77kZSnbqK7yfovp5qX3JRnbE0xJJGKjPNbEfYqox/r6hie6cdaxwlQOyfe7O 6mkIMs6VeczCQDMNEiI4A2bFnqj8nqpAalOIuhVr8OYlYsIolIqOvgVe/KLqzYFa9Znplip9uNjNP +rbIOsk31eIocSDlln6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSH2F-0006ZI-No; Wed, 06 Nov 2019 08:51:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSH29-0006YK-Ci; Wed, 06 Nov 2019 08:51:26 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEF01206A3; Wed, 6 Nov 2019 08:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573030281; bh=w6b84J95hMSFCMrNJ2Y6lTW2n32w6MgoawbJHdh7P1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dW9xxWMWUJBaK7ZxY8oQzAK0S/mxveM6NTSB+edw0UZObbVssvETBVtZY0RqbeuOt XLf/Jmfit+5Ckq8megXEtg5llMPFQXL+WQ4K9vDeRoD+yaAnVkj6/1ex+Ns5RG4VLx 3rR88rpuU6NpthEDCxdvYWmC/nw+SFxNfXV7zGIQ= Date: Wed, 6 Nov 2019 09:51:17 +0100 From: Greg Kroah-Hartman To: Wolfram Sang Subject: Re: [PATCH 01/28] usb: common: change usb_debug_root as static variable Message-ID: <20191106085117.GB2971560@kroah.com> References: <8cb137d5376b4e317dc22dcb9e81a1125b781f8f.1573008519.git.chunfeng.yun@mediatek.com> <79fd2ebd-b8c6-ee00-c71e-782475a20de6@roeck-us.net> <20191106073310.GA1085@ninjato> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191106073310.GA1085@ninjato> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_005124_931318_67A6AD43 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , Alexandre Belloni , Heikki Krogerus , "Gustavo A. R. Silva" , Yangtao Li , Linus Walleij , linux-kernel@vger.kernel.org, Matthias Brugger , Mans Rullgard , Srinivas Kandagatla , Laurent Pinchart , Fabio Estevam , Florian Fainelli , Robert Jarzmik , Kevin Cernekee , Ludovic Desroches , Alan Stern , NXP Linux Team , Chunfeng Yun , bcm-kernel-feedback-list@broadcom.com, David Kershner , Hans Ulli Kroll , Cristian Birsan , linux-media@vger.kernel.org, Fabrizio Castro , Mathias Payer , Mathias Nyman , Suzuki K Poulose , Sascha Hauer , Haojian Zhuang , Stephen Boyd , linux-mediatek@lists.infradead.org, Minas Harutyunyan , Simon Horman , Mauro Carvalho Chehab , Bin Liu , linux-arm-kernel@lists.infradead.org, Biju Das , Felipe Balbi , Laurentiu Tudor , Yoshihiro Shimoda , linux-usb@vger.kernel.org, Nicolas Ferre , Dmitry Torokhov , Guenter Roeck , Pengutronix Kernel Team , Colin Ian King , Shawn Guo , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Nov 06, 2019 at 08:33:10AM +0100, Wolfram Sang wrote: > > > Did exported variables run out of favor ? Sorry if there was a > > patch 0 of the series explaining the rationale and I missed it. > > I neither got it if there was one. If there wasn't, I agree a cover > letter makes a lot of sense here. I don't understand why this whole series is needed either. What is wrong with the original code? Also, like I said before, you broke the build here with the first patch, which is not ok. greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek