Re: [PATCH 01/28] usb: common: change usb_debug_root as static variable - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Peter Chen <Peter.Chen@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	Yangtao Li <tiny.windzz@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Mans Rullgard <mans@mansr.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Fabio Estevam <festevam@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Kevin Cernekee <cernekee@gmail.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	NXP Linux Team <linux-imx@nxp.com>,
	bcm-kernel-feedback-list@broadcom.com,
	David Kershner <david.kershner@unisys.com>,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	Cristian Birsan <cristian.birsan@microchip.com>,
	linux-media@vger.kernel.org,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
	Mathias Payer <mathias.payer@nebelwelt.net>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Stephen Boyd <swboyd@chromium.org>,
	linux-mediatek@lists.infradead.org,
	Minas Harutyunyan <hminas@synopsys.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Bin Liu <b-liu@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	Biju Das <biju.das@bp.renesas.com>,
	Felipe Balbi <balbi@kernel.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	linux-usb@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Dmitry Torokhov <dtor@chromium.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Colin Ian King <colin.king@canonical.com>,
	Shawn Guo <shawnguo@kernel.org>, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH 01/28] usb: common: change usb_debug_root as static variable
Date: Wed, 6 Nov 2019 09:51:41 +0100	[thread overview]
Message-ID: <20191106085141.GC2971560@kroah.com> (raw)
In-Reply-To: <8cb137d5376b4e317dc22dcb9e81a1125b781f8f.1573008519.git.chunfeng.yun@mediatek.com>

On Wed, Nov 06, 2019 at 11:15:02AM +0800, Chunfeng Yun wrote:
> Try to avoid using extern global variable, and provide two
> functions for the usage cases
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  drivers/usb/common/common.c | 16 ++++++++++++++--
>  include/linux/usb.h         |  5 ++++-
>  2 files changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/common/common.c b/drivers/usb/common/common.c
> index 1433260d99b4..639ee6d243a2 100644
> --- a/drivers/usb/common/common.c
> +++ b/drivers/usb/common/common.c
> @@ -293,8 +293,20 @@ struct device *usb_of_get_companion_dev(struct device *dev)
>  EXPORT_SYMBOL_GPL(usb_of_get_companion_dev);
>  #endif
>  
> -struct dentry *usb_debug_root;
> -EXPORT_SYMBOL_GPL(usb_debug_root);
> +static struct dentry *usb_debug_root;

You just broke the kernel build, which is not acceptable at all :(

greg k-h

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek