From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sandesh Kenjana Ashok <sandeshkenjanaashok@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: mt7621-pinctrl: Align code by cleanup long lines
Date: Wed, 22 Jan 2020 11:17:53 +0300 [thread overview]
Message-ID: <20200122081753.GE1847@kadam> (raw)
In-Reply-To: <20200121195218.GA10666@SandeshPC>
On Tue, Jan 21, 2020 at 08:52:18PM +0100, Sandesh Kenjana Ashok wrote:
> Cleanup lines over 80 characters in pinctrl-rt2880.c.
> Issue found by checkpatch.pl
>
> Signed-off-by: Sandesh Kenjana Ashok <sandeshkenjanaashok@gmail.com>
> ---
> drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
> index d0f06790d38f..254d4eb88f5f 100644
> --- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
> +++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
> @@ -159,8 +159,8 @@ static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev,
> }
>
> static int rt2880_pmx_group_gpio_request_enable(struct pinctrl_dev *pctrldev,
> - struct pinctrl_gpio_range *range,
> - unsigned int pin)
> + struct pinctrl_gpio_range *range,
> + unsigned int pin)
> {
> struct rt2880_priv *p = pinctrl_dev_get_drvdata(pctrldev);
Now it has a new warning.
CHECK: Alignment should match open parenthesis
#162: FILE: drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:162:
+static int rt2880_pmx_group_gpio_request_enable(struct pinctrl_dev *pctrldev,
+ struct pinctrl_gpio_range *range,
Just leave it. The original is fine.
regards,
dan carpenter
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2020-01-22 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 19:52 [PATCH] staging: mt7621-pinctrl: Align code by cleanup long lines Sandesh Kenjana Ashok
2020-01-22 8:17 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122081753.GE1847@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sandeshkenjanaashok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).