From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC6CC3F2D1 for ; Mon, 2 Mar 2020 23:37:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08D7E2465E for ; Mon, 2 Mar 2020 23:37:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cYwZhQyb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08D7E2465E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G1tvAVzB/mWTj+9V6AFy1/9KLn8PJjhKATgL9ZTp2Cc=; b=cYwZhQybyeeZoT g1Ny9fGNWY86ZIyYf/IrN8JsGF01/3hZL4f5+e1m6olpA70RcsNGmY5XAf55Le8I7X6J2T2VpV/3M 2Sxz2R27U8xYHE9iH1olPqObfknk7SLtgx4vpM5tnWSsCLkHKbmQTHcrahewI3kKsrtkvsFlgHYi7 cErcNgPLNd9Zd+mD1Y+cKOsjyMpsueAInTCFLkyHF97KDmsrykGQecCHwAqCZARQI4GdRFWV6dYWe YeMhCIrAwAzJAh1rXh9di+JSN7xGkrIzeEBDo1dtIzTS9snMpTf5WZD0u8hBhiVMphu9fSDms/8aL qJ9i6RnWcliqeODY0LyA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8ucn-00035I-4B; Mon, 02 Mar 2020 23:37:25 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8ucj-00034K-HE; Mon, 02 Mar 2020 23:37:23 +0000 Received: by mail-ot1-f68.google.com with SMTP id x19so1160527otp.7; Mon, 02 Mar 2020 15:37:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yFtkRGnfBiqCKQ/AHJ5vc+ttuYQAJORgEqP2QzLRI4E=; b=p+rYzLMik0O1tWO+J90hykS8dIkgj3rAzkkg/k+orZ0Cf8oI8ZLA05dxkXkbiGe9dZ xQEnoJT2+AbgIYICNpYBygqyrLtzGrbf9OHdd1PdDKsyqNiaC1peeiJRzOP2DJ4fIyhy F3xVRFA7DhW8DAW0aq0I0HRlxRP9g3Qk3J5G3GilfSFnRYU0BbPA+oK0oHP8XpC0XTMM 3+kAKEXrheHcfCtBlfPUJLeGyGfI529gf0y+FU5MNrFV370JnKEC7wEzeo5sjLepOJY6 JV18F4RSpkuj326Y/iFSJLfkfTAYdPUODmq+23Q4cGGXVrKrRCJEpU5nSaVmhlFAf61L /few== X-Gm-Message-State: ANhLgQ1UY0mw+C8FeSUHz/weKBZeDKj3TyoaPNrf9f35s9M28SksgBuR 7vNMtC7kkri6ok2lHhEOoA== X-Google-Smtp-Source: ADFU+vt6ffPV7eEC+tPPHGqHxdSzbQJgCj5vAUVFRez1j/cR9fGNitZz5dMCB0NLTh45Ua8HyFRokQ== X-Received: by 2002:a9d:638f:: with SMTP id w15mr1297268otk.239.1583192240162; Mon, 02 Mar 2020 15:37:20 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id r205sm6920647oih.54.2020.03.02.15.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 15:37:19 -0800 (PST) Received: (nullmailer pid 16189 invoked by uid 1000); Mon, 02 Mar 2020 23:37:18 -0000 Date: Mon, 2 Mar 2020 17:37:18 -0600 From: Rob Herring To: Jitao Shi Subject: Re: [PATCH v11 4/6] dt-bindings: display: mediatek: convert the document format from txt to yaml Message-ID: <20200302233718.GA5639@bogus> References: <20200228081441.88179-1-jitao.shi@mediatek.com> <20200228081441.88179-5-jitao.shi@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200228081441.88179-5-jitao.shi@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200302_153721_573676_F0CE1DF4 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, bibby.hsieh@mediatek.com, srv_heupstream@mediatek.com, David Airlie , huijuan.xie@mediatek.com, stonea168@163.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, cawa.cheng@mediatek.com, ck.hu@mediatek.com, linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Feb 28, 2020 at 04:14:39PM +0800, Jitao Shi wrote: > Signed-off-by: Jitao Shi > --- > .../display/mediatek/mediatek,dpi.txt | 45 -------- > .../display/mediatek/mediatek,dpi.yaml | 100 ++++++++++++++++++ > 2 files changed, 100 insertions(+), 45 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > deleted file mode 100644 > index 4eeead1d39db..000000000000 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > +++ /dev/null > @@ -1,45 +0,0 @@ > -Mediatek DPI Device > -=================== > - > -The Mediatek DPI function block is a sink of the display subsystem and > -provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel > -output bus. > - > -Required properties: > -- compatible: "mediatek,-dpi" > - the supported chips are mt2701 , mt8173 and mt8183. > -- reg: Physical base address and length of the controller's registers > -- interrupts: The interrupt signal from the function block. > -- clocks: device clocks > - See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. > -- clock-names: must contain "pixel", "engine", and "pll" > -- port: Output port node with endpoint definitions as described in > - Documentation/devicetree/bindings/graph.txt. This port should be connected > - to the input port of an attached HDMI or LVDS encoder chip. > - > -Optional properties: > -- pinctrl-names: Contain "gpiomode" and "dpimode". > - pinctrl-names see Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > -- pclk-sample: refer Documentation/devicetree/bindings/media/video-interfaces.txt. > - > -Example: > - > -dpi0: dpi@1401d000 { > - compatible = "mediatek,mt8173-dpi"; > - reg = <0 0x1401d000 0 0x1000>; > - interrupts = ; > - clocks = <&mmsys CLK_MM_DPI_PIXEL>, > - <&mmsys CLK_MM_DPI_ENGINE>, > - <&apmixedsys CLK_APMIXED_TVDPLL>; > - clock-names = "pixel", "engine", "pll"; > - pinctrl-names = "active", "idle"; > - pinctrl-0 = <&dpi_pin_func>; > - pinctrl-1 = <&dpi_pin_idle>; > - > - port { > - dpi0_out: endpoint { > - pclk-sample = <0>; > - remote-endpoint = <&hdmi0_in>; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > new file mode 100644 > index 000000000000..9878e9f2b12e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -0,0 +1,100 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/mediatek,dpi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: mediatek DPI Controller Device Tree Bindings > + > +maintainers: > + - CK Hu > + - Rob Herring > + - Mark Rutland Should be the owner of this device/driver, not Mark or me. > + > +description: | > + The Mediatek DPI function block is a sink of the display subsystem and > + provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel > + output bus. > + > +properties: > + compatible: > + enum: > + - mediatek,mt2701-dpi > + - mediatek,mt8173-dpi > + - mediatek,mt8183-dpi > + > + reg: > + maxItems: 1 > + description: Physical base address and length of the controller's registers Drop, that's every 'reg'. Plus there's an error in indentation. > + > + interrupts: > + maxItems: 1 > + description: The interrupt signal from the function block. Drop 'description'. > + > + clocks: > + minItems: 3 > + maxItems: 3 Drop minItems/maxItems. Redundant with the items list. > + items: > + - description: Pixel Clock > + - description: Engine Clock > + - description: DPI PLL > + > + clock-names: > + items: > + - const: pixel > + - const: engine > + - const: pll > + > + pinctrl-names: > + description: pinctrl-names refe Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt Drop. > + minItems: 2 > + maxItems: 2 Drop. > + items: > + - const: active > + - const: idle See my comment on patch 2 of v9. > + > + port: > + type: object > + description: > + Output port node with endpoint definitions as described in > + Documentation/devicetree/bindings/graph.txt. This port should be connected > + to the input port of an attached HDMI or LVDS encoder chip. > + > + pclk-sample: > + description: refer Documentation/devicetree/bindings/media/video-interfaces.txt. > + maxItems: 1 Not an array, so maxItems isn't right. If there's no constraints on the values, then just drop maxItems. This also in the wrong place. It has to be under port and endpoint. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + dpi0: dpi@1401d000 { > + compatible = "mediatek,mt8173-dpi"; > + reg = <0 0x1401d000 0 0x1000>; > + interrupts = ; > + clocks = <&mmsys CLK_MM_DPI_PIXEL>, > + <&mmsys CLK_MM_DPI_ENGINE>, > + <&apmixedsys CLK_APMIXED_TVDPLL>; > + clock-names = "pixel", "engine", "pll"; > + pinctrl-names = "active", "idle"; > + pinctrl-0 = <&dpi_pin_func>; > + pinctrl-1 = <&dpi_pin_idle>; > + > + port { > + reg = <0>; Wrong indentation. > + dpi0_out: endpoint { > + pclk-sample = <0>; > + remote-endpoint = <&hdmi0_in>; > + }; > + }; > + }; > + > +... > -- > 2.21.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek