From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA38C2BA19 for ; Wed, 15 Apr 2020 12:30:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B7C120936 for ; Wed, 15 Apr 2020 12:30:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mGW/2/K2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B7C120936 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OzrcrblU7WCmRw4wnKXXyXfvB2HlMT7JH1ZbnigyD6Y=; b=mGW/2/K2GUYXon FH2F+xSNDTPCbzFBfjier+GELqzA39ruEyFUketIr5JYDL8oaUDNcSabnVdaAp+V4vs43E/AS6+HE yP9se7n4R//0TLCRKXdnkJJ0YBmvBqWEdxRvdNQ75CHzOyRr4xC7IC5VZnK1Wkme2Equ77vU3jBX8 vzP2vJw+3N2IJgnFwOI2ju1OMA9RYsQ6/3jzHnEoLvD21Cvy8kIcSsmd5DhJI0PBAhXhwbFExfTEP UgKiWWaVefRHwRV+zxZwBJptlQwYMLOqxQT1YP21B6KsiAJCIT6P+/DT/Z46GEC6xKa6tcYgZh06F LeYH6jsFH70P0ZkXgpGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOhB2-0005UG-8h; Wed, 15 Apr 2020 12:30:00 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOhAp-000586-MC; Wed, 15 Apr 2020 12:29:49 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7F854AC11; Wed, 15 Apr 2020 12:29:42 +0000 (UTC) Date: Wed, 15 Apr 2020 14:29:40 +0200 From: Joerg Roedel To: Lu Baolu Subject: Re: [PATCH v2 13/33] iommu: Export bus_iommu_probe() and make is safe for re-probing Message-ID: <20200415122940.GB21899@suse.de> References: <20200414131542.25608-1-joro@8bytes.org> <20200414131542.25608-14-joro@8bytes.org> <1853992c-47a6-3724-812c-a52558c13732@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1853992c-47a6-3724-812c-a52558c13732@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_052947_874368_D90DF643 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Bjorn Andersson , linux-tegra@vger.kernel.org, Thierry Reding , Will Deacon , Marek Szyprowski , Jean-Philippe Brucker , linux-samsung-soc@vger.kernel.org, Joerg Roedel , Rob Clark , Krzysztof Kozlowski , Jonathan Hunter , linux-rockchip@lists.infradead.org, Andy Gross , linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , virtualization@lists.linux-foundation.org, Gerald Schaefer , David Woodhouse , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Kukjin Kim , Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Baolu, On Wed, Apr 15, 2020 at 02:10:03PM +0800, Lu Baolu wrote: > On 2020/4/14 21:15, Joerg Roedel wrote: > > > + /* Device is probed already if in a group */ > > + if (iommu_group_get(dev) != NULL) > > Same as > if (iommu_group_get(dev)) > ? > > By the way, do we need to put the group if device has already been > probed? Right, fixed both, thank you. Regards, Joerg _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek