From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E185EC2BA2B for ; Fri, 17 Apr 2020 01:03:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B37B820776 for ; Fri, 17 Apr 2020 01:03:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Oh77UogK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=endlessm-com.20150623.gappssmtp.com header.i=@endlessm-com.20150623.gappssmtp.com header.b="FrdtkA3N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B37B820776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=endlessm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YscoIJdVwIrbKjH32O+wF4YJimlQ/pIa/00gjfMvo/4=; b=Oh77UogKmJpxSG voDZITfhR3kqHWlNendjG4IsjkJ1Q/oK8BPFcc79vaWnReOC9C4Tce3XZ/qKMNqPvKyWZuADJYmFn B4Szer9qs8ClxhfrMFSP58Z2hdryGDljzr1YKdbU7JxOwo1eSIzl5/vwanMQkLGGfnjTogoMBsyxY TBJheqtcolN754/MpELgljNrsdbFwVR1GDxxwVH98re77RuDi4Bh3uLGh5fYA0ZcAb7snoPTX2ve3 e508pvKH1NUA7FPrIxOL4OyZ+pEx4dHZ1dHjCt24P7wpP8qH/gklO1bLhnlHM7ZOjNnFcPwp5u3iZ 4LXMZGXM5yasX+G8dWxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPFQ5-0004vO-3v; Fri, 17 Apr 2020 01:03:49 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPFQ1-0004ue-Gh for linux-mediatek@lists.infradead.org; Fri, 17 Apr 2020 01:03:48 +0000 Received: by mail-pl1-x643.google.com with SMTP id t4so308549plq.12 for ; Thu, 16 Apr 2020 18:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0ZL5DKQEN5tIRYMA9bsAF7qYyxlNKGNuVSjiADQ9SPk=; b=FrdtkA3N/A0B10cQBR1BRxqf+/pg1uBkd6DO7lHtdKgOqGpk1/7USrxTk4rdlzJ0Pn oQGe7ba6HSEplsOy6ec3K4H8Fpx1j9/0meJ+gk7xvdUqFq7CDtsNxsMJzjX3kGdDbbz8 GCSySEUU8oXzqHDM2sby4knjcPLSSaIgNvaO9PtWZWWefGILL8HPrNXdIlKHYq2YILWZ AMHiZb/IAXXMBCtRYZZ2S6R7t7InyUg113cLru837l9P5It247de3hDzpXYYYkdzsiNW l3eKB2Wxab5vn9CTNWz5BkklF52xIUVdN24g+AL8C9OhFHLjLh5Ls1ropaQnpLD31b3o DqaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ZL5DKQEN5tIRYMA9bsAF7qYyxlNKGNuVSjiADQ9SPk=; b=NZxfoFOeU5q+wGBrMVcoO/h4rogoUCpAkxIkxdEX6+UJW0tBk8OoypbPFDbmX6xk9h QDSNZFJjhtfyuSayFchFFOYC6gAabLNjEN4d8VB+eDu/WlBKbgwzKnOecQGEwnlSw0Gy OJXYgqpo71C/oZTsteWtA89tZ9U95c9Nin+TPPMCj/N/WdOoUZUqNsLb/9+oAL9o/svD Xi3zpcSx2NFe9ifL7Bx/Xhh8pLo9OHFTN7gLw/UuA6E/yAgIMCguEKZ29Rvj/WOLj+PC sJOtTdNoiOGW38J3x5S6BIybvj+pv/Bfs9T5vrHvo2KOc1SNXPlTBjFtjxO/QrVYLANF /J4A== X-Gm-Message-State: AGi0PuYO75saWAkMoZjbB/25OL9CG0UQ2KaYZu1WKiIQ+r9xvPZOBDRg DPJtGI4z19omcjzuJfF8WyiufQ== X-Google-Smtp-Source: APiQypKfJXVVs8nt0ABNaLviRVVB2FF8oWh5BJ43V1JXuqqLWnC3nHs+J6exlmUfG8/Dws2LqNNTtg== X-Received: by 2002:a17:902:fe09:: with SMTP id g9mr366208plj.171.1587085424144; Thu, 16 Apr 2020 18:03:44 -0700 (PDT) Received: from limbo.local (host-160.218-14-119.dynamic.totalbb.net.tw. [119.14.218.160]) by smtp.gmail.com with ESMTPSA id u8sm16518026pgl.19.2020.04.16.18.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2020 18:03:43 -0700 (PDT) From: Daniel Drake To: joro@8bytes.org Subject: Re: [PATCH v2 00/33] iommu: Move iommu_group setup to IOMMU core code Date: Fri, 17 Apr 2020 09:03:35 +0800 Message-Id: <20200417010335.31739-1-drake@endlessm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200414131542.25608-1-joro@8bytes.org> References: <20200414131542.25608-1-joro@8bytes.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_180345_606711_C6BA07F7 X-CRM114-Status: UNSURE ( 8.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heiko@sntech.de, bjorn.andersson@linaro.org, linux-tegra@vger.kernel.org, thierry.reding@gmail.com, will@kernel.org, m.szyprowski@samsung.com, jean-philippe@linaro.org, linux-samsung-soc@vger.kernel.org, robdclark@gmail.com, krzk@kernel.org, jonathanh@nvidia.com, linux-rockchip@lists.infradead.org, agross@kernel.org, jonathan.derrick@intel.com, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, virtualization@lists.linux-foundation.org, gerald.schaefer@de.ibm.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, kgene@kernel.org, robin.murphy@arm.com, baolu.lu@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Joerg, > Hi, > > here is the second version of this patch-set. The first version with > some more introductory text can be found here: > > https://lore.kernel.org/lkml/20200407183742.4344-1-joro@8bytes.org/ Thanks for the continued improvements in this area! I may have spotted a problem with setups like VMD. The core PCI bus is set up during early boot. Then, for the PCI bus, we reach iommu_bus_init() -> bus_iommu_probe(). In there, we call probe_iommu_group() -> dev_iommu_get() for each PCI device, which allocates dev->iommu in each case. So far so good. The problem is that this is the last time that we'll call dev_iommu_get(). If any PCI bus devices get added after this point, they do not get passed to dev_iommu_get(). So when the vmd module gets loaded later, and creates more PCI devices, we end up in iommu_bus_notifier() -> iommu_probe_device() -> __iommu_probe_device() which does: dev->iommu->iommu_dev = iommu_dev; dev->iommu-> is a NULL dereference because dev_iommu_get() was never called for this new device. Daniel _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek