From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EBBEC83000 for ; Tue, 28 Apr 2020 13:40:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2E44206D7 for ; Tue, 28 Apr 2020 13:40:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZI27zEqs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cVkICW4Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2E44206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gtfoDIpFG05UDvWtUwWaidTbgoe4O8PxOyKuxLuJmhw=; b=ZI27zEqsmdRAYL 0YHilZ85KJPPolXxMVQw+qk3YzOo+BTJmpPwmCqCwNh+OITLiRcSXqKGlI3EpQl1K/68GydAldyge cqHC1Szv5Y/t1w2Cgh+Dd0JVs/eadz/k+mdNKOr8hbYKPF22yancetf8gIWRv7tFHBFfCTNoaPYZK vkXmLU6gp78ZWwkWqyzrcEBDCb4iyKA5hJzp8/YVm7YRjb0JC4ZYJMCgyhcCH7N7kJTZCR+zD4q3r UuJSUFYpSf43odrb0f00CFhgkMvjiZfv5SZDJGc6Mlb7BZDGqEKt5XuMKFDSenh6JELXQbmQZu65J do+Y9OE6nBATBxiM/jJQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTQTX-0007bE-Pv; Tue, 28 Apr 2020 13:40:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTQT8-0006N8-Mf; Tue, 28 Apr 2020 13:40:16 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC285206D7; Tue, 28 Apr 2020 13:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588081213; bh=z6FwCpZc4bewQTILO5ed54oDlhcVRcQNbY1dTaBbd6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cVkICW4Z7Gqg9PFeTpJx749wpYdzY1xShHb2yMmN+xaT45MjnilFD+afecPd9dSto sCzuyHDpAkyNOtqJYSPbwgTSTHwvuxcIZn0gS4NvHa860NVVh5lfoqvwLdsHACsIrT W/NEXMgeOvEPPtZv63J1pgPB/026WMACNMYwLFKI= Date: Tue, 28 Apr 2020 15:40:10 +0200 From: Greg KH To: John Oldman Subject: Re: [PATCH] Staging: mt7621-dma: mtk-hsdma.c: Fix Missing a blank line after declarations Message-ID: <20200428134010.GA1374852@kroah.com> References: <20200426161319.23941-1-john.oldman@polehill.co.uk> <20200426170719.GA2138855@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200428_064014_859158_4F3A8057 X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Apr 28, 2020 at 02:21:25PM +0100, John Oldman wrote: > I was not so happy about this one, even though I went and committed it. > > Without the blank line checkpatch reports: > > WARNING: Missing a blank line after declarations > #160: FILE: drivers/staging/mt7621-dma/mtk-hsdma.c:160: > + struct tasklet_struct task; > + volatile unsigned long chan_issued; > > So I dumly inserted a blank line to silence checkpatch. As checkpatch is just a simple script, it is not always right, don't blindly follow it. > In hindsight maybe a false positive, blank lines in a struct might not be > helpful. It can be, but not here. thanks, greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek