Re: [SPAM]RE: [PATCH v5 2/8] scsi: ufs: introduce fixup_dev_quirks vops

Stanley Chu
2020-05-07T23:57:20Z

Hi Avri,

On Mon, 2020-05-04 at 22:41 +0800, Stanley Chu wrote:
> Hi Avri,
>
> On Mon, 2020-05-04 at 10:38 +0000, Avri Altman wrote:
> > >
> > > ufs_fixup_device_setup(hba);
> > > + ufshcd_vops_fixup_dev_quirks(hba);
> > Maybe call your new ufshcd_vops_fixup_dev_quirks as part of ufs_fixup_device_setup
>
> The latter patch exports ufs_fixup_device_setup() for vendors to re-use
> it to parse vendor-specific device quirk table during the call of
> ufshcd_vops_fixup_dev_quirks(), thus ufshcd_vops_fixup_dev_quirks()
> cannot be as part of ufs_fixup_device_setup().

Maybe I could use a new function to contain ufs_fixup_device_setup() and
ufshcd_vops_fixup_dev_quirks() to make the code more clear here.

Thanks,
Stanley Chu