Re: [V8, 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings

Sakari Ailus
2020-05-11T19:55:13Z

Hi Rob,

On Mon, May 11, 2020 at 11:02:07AM -0500, Rob Herring wrote:
> On Sat, May 09, 2020 at 04:06:26PM +0800, Dongchun Zhu wrote:
...

> > + properties:
> > + endpoint:
> > + type: object
> > +
> > + properties:
> > + data-lanes:
> > + description: |-
> > + The driver only supports 1-lane operation.
>
> What the driver supports is not relevant.
>
> > + items:
> > + - const: 1
> > + - const: 2
> > + - const: 3
> > + - const: 4
> > +
> > + clock-noncontinuous:
> > + type: boolean
> > + description: |-
> > + MIPI CSI-2 clock is non-continuous if this property is present,
> > + otherwise it's continuous.
>
> Assume this has a common definition, so just need:
>
> clock-noncontinuous: true
>

...

> > + data-lanes = <1>;
>
> This doesn't match the schema which says this should be 4 entries.

I believe the intent has been to say there would be 1, 2, 3 or 4 entries
--- i.e. the number of lanes.

--
Kind regards,

Sakari Ailus